Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(blockifier): make warning more concise #1563

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

aner-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@aner-starkware aner-starkware force-pushed the aner/make_warning_more_concise branch from 550423e to 88a04f5 Compare October 27, 2024 08:53
Copy link

Artifacts upload triggered. View details here

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @aner-starkware)

Copy link

Artifacts upload triggered. View details here

Copy link

codecov bot commented Oct 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 67.32%. Comparing base (e3165c4) to head (88a04f5).
Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
crates/blockifier/src/blockifier/block.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1563       +/-   ##
===========================================
+ Coverage   40.10%   67.32%   +27.21%     
===========================================
  Files          26      102       +76     
  Lines        1895    13688    +11793     
  Branches     1895    13688    +11793     
===========================================
+ Hits          760     9215     +8455     
- Misses       1100     4068     +2968     
- Partials       35      405      +370     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aner-starkware aner-starkware merged commit 67997ef into main Oct 27, 2024
12 checks passed
@aner-starkware aner-starkware deleted the aner/make_warning_more_concise branch October 27, 2024 11:43
@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants