feat(blockifier): add deploy syscall implementation

[varex83]

No description provided.

[reviewable-StarkWare]

This change is 

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.07%. Comparing base (e3165c4) to head (9de0e66).
Report is 402 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1554       +/-   ##
===========================================
+ Coverage   40.10%   69.07%   +28.96%     
===========================================
  Files          26      105       +79     
  Lines        1895    13658    +11763     
  Branches     1895    13658    +11763     
===========================================
+ Hits          760     9434     +8674     
- Misses       1100     3821     +2721     
- Partials       35      403      +368     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[meship-starkware]

Reviewed 1 of 2 files at r2, 1 of 1 files at r3, 3 of 8 files at r6, 1 of 3 files at r7, 2 of 4 files at r8, all commit messages.
Reviewable status: 8 of 11 files reviewed, 1 unresolved discussion (waiting on @noaov1 and @varex83)

---

crates/blockifier/feature_contracts/cairo_native/test_contract.cairo line 79 at r8 (raw file):

        contract_address_0: ContractAddress,
        entry_point_selector_0: felt252,
        calldata_0: Array::<felt252>,

This shouldn't be part of this PR

[meship-starkware]

Reviewed 1 of 8 files at r6, 1 of 4 files at r8.
Reviewable status: 10 of 11 files reviewed, 2 unresolved discussions (waiting on @noaov1 and @varex83)

---

crates/blockifier/src/execution/native/utils.rs line 31 at r8 (raw file):

    match String::from_utf8(bytes_err) {
        Ok(s) => s.trim_matches('\0').to_owned(),
        Err(_) => {

Shouldn't be part of this PR

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[meship-starkware]

Reviewed 1 of 1 files at r18, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noaov1 and @Yoni-Starkware)

[github-actions]

Artifacts upload triggered. View details here

[varex83]

Reviewable status: 32 of 35 files reviewed, 1 unresolved discussion (waiting on @meship-starkware, @noaov1, and @Yoni-Starkware)

---

crates/blockifier/src/execution/native/entry_point_execution.rs line 45 at r12 (raw file):

Previously, varex83 (Bohdan Ohorodnii) wrote…

We've added it since some of the errors from the native go into the "Ok", but tests were expecting it to be an error, so we've returned to this approach. I believe this will be refactored in the way that the error native syscall returns triple: Ok(..), RuntimeError(...), UnexpectedError(...) (for example some conversion problem).

If we remove this part of the code, we must rewrite tests, and native code won't be compatible with VM returns. We've also put it here since not all syscall tests are dependent on it.

Should be removed now

[avi-starkware]

Reviewed 1 of 2 files at r16, 3 of 3 files at r19, all commit messages.
Dismissed @noaov1 from a discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Yoni-Starkware)

[avi-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Yoni-Starkware)

[meship-starkware]

Reviewed 3 of 3 files at r19, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Yoni-Starkware)

[Yoni-Starkware]

Reviewed 1 of 3 files at r7, 26 of 30 files at r10, 3 of 3 files at r11, 1 of 2 files at r12, 1 of 2 files at r16, 3 of 3 files at r19, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @varex83)

[meship-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @varex83)

[meship-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @varex83)

---

a discussion (no related file):
Please rebase to resolve conflicts

[meship-starkware]

Reviewed 4 of 4 files at r20, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @varex83)

[github-actions]

Artifacts upload triggered. View details here

[meship-starkware]

Reviewed 1 of 1 files at r21, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @varex83)

[github-actions]

Artifacts upload triggered. View details here

[meship-starkware]

Reviewed 1 of 1 files at r22, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @varex83)

fixed

[meship-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @varex83)

[meship-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @varex83)