feat(blockifier): add emit_event cairo native syscall

[PearsonWhite]

Implements the emit_event syscall for native cairo syscall handler.

[reviewable-StarkWare]

This change is 

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[PearsonWhite]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion

a discussion (no related file):
I'm looking for more clarification on the expected error return behavior. For errors that are not of the type SyscallExecutionError::SyscallError, I'm currently using .expect(...), which causes tests to fail in some syscall PRs. This can be handled in several ways. There is currently a discussion on this topic here: https://reviewable.io/reviews/starkware-libs/sequencer/1305#-O96F70GASwm5B06IRKL

---

[varex83]

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @PearsonWhite)

---

crates/blockifier/src/execution/native/syscall_handler.rs line 261 at r1 (raw file):

            &event,
        )
        .expect("Number of events exceeded the size limit.");

This should be returned as a runtime error, not expect

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.12%. Comparing base (e3165c4) to head (3659533).
Report is 407 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1550       +/-   ##
===========================================
+ Coverage   40.10%   69.12%   +29.02%     
===========================================
  Files          26      105       +79     
  Lines        1895    13701    +11806     
  Branches     1895    13701    +11806     
===========================================
+ Hits          760     9471     +8711     
- Misses       1100     3827     +2727     
- Partials       35      403      +368     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[PearsonWhite]

Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @varex83)

a discussion (no related file):

Previously, PearsonWhite wrote…

I'm looking for more clarification on the expected error return behavior. For errors that are not of the type SyscallExecutionError::SyscallError, I'm currently using .expect(...), which causes tests to fail in some syscall PRs. This can be handled in several ways. There is currently a discussion on this topic here: https://reviewable.io/reviews/starkware-libs/sequencer/1305#-O96F70GASwm5B06IRKL

Changed this. Currently returning errors as encoded Felts in the retdata.

---

---

crates/blockifier/src/execution/native/syscall_handler.rs line 261 at r1 (raw file):

Previously, varex83 (Bohdan Ohorodnii) wrote…

This should be returned as a runtime error, not expect

Done.

[xrvdg]

crates/blockifier/src/execution/native/utils.rs line 25 at r2 (raw file):

}

pub fn decode_felts_as_str(encoding: &[Felt]) -> String {

There's a function called format_panic_data that has the exact same signature. Could that be used instead?

[github-actions]

Artifacts upload triggered. View details here

[PearsonWhite]

Reviewable status: 0 of 3 files reviewed, 4 unresolved discussions (waiting on @varex83 and @xrvdg)

---

crates/blockifier/src/execution/native/utils.rs line 25 at r2 (raw file):

Previously, xrvdg (Xander van der Goot) wrote…

There's a function called format_panic_data that has the exact same signature. Could that be used instead?

format_panic_data is meant for a Vec of Felts that are short strings, and thus are limited to 31 characters. Longer explanation below:

I think format_panic_data is used for an array of Felts where each Felt is an error in the format:
(<felt_as_str_as_felt> ('<str_as_felt>'), where the Felt represents a short string. For example, it would take the felt array slice: [0x7820213d2079] and return the String (0x7820213d2079 ('x != y')

But the Vec<Felt> from call_info.execution.retdata.0 in this case was created with encode_str_as_felts (String->Vec). Each Felt is not meant to independent; it's just part of the string. format_panic_data would interpret each Felt as an error, see that it can be interpreted as a string, output the format above, and join it with the other results. You would get the following:

"(0x457863656564656420746865206d6178696d756d206b657973206c656e6774 ('Exceeded the maximum keys lengt'), 0x682c206b657973206c656e6774683a2035312c206d6178206b657973206c65 ('h, keys length: 51, max keys le'), 0x6e6774683a2035302e00000000000000000000000000000000000000000000 ('ngth: 50.'))"

[github-actions]

Artifacts upload triggered. View details here

[meship-starkware]

Reviewed 1 of 3 files at r4, 4 of 4 files at r7, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @avi-starkware and @xrvdg)

[xrvdg]

Reviewed 4 of 4 files at r7, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @avi-starkware and @Yoni-Starkware)

[meship-starkware]

Dismissed @xrvdg from 2 discussions.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @avi-starkware and @Yoni-Starkware)

[meship-starkware]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @avi-starkware and @Yoni-Starkware)

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[meship-starkware]

Reviewed 2 of 2 files at r8, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Yoni-Starkware)

[avi-starkware]

Reviewed 2 of 2 files at r8, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Yoni-Starkware)

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[Yoni-Starkware]

Reviewed 1 of 3 files at r4, 2 of 4 files at r7, 2 of 2 files at r9, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avi-starkware, @meship-starkware, @noaov1, @varex83, and @xrvdg)

[Yoni-Starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avi-starkware, @meship-starkware, @noaov1, @varex83, and @xrvdg)

[Yoni-Starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @PearsonWhite)