feat(blockifier): add library_call cairo native syscall

[PearsonWhite]

Implements library_call in the NativeSyscallHandler.

[reviewable-StarkWare]

This change is 

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[PearsonWhite]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion

a discussion (no related file):
test_nested_library_call fails due to a difference in ExecutionResources when comparing the CallInfo to the expected. The expected CallInfo is the same between the VM and Native. Eventually, these should be the same (right?), but for now it fails. How would you like me to address this? I could change the test to ignore ExecutionResources in the comparison for now, or mark the test as #[ignored]

---

[varex83]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @PearsonWhite)

a discussion (no related file):

Previously, PearsonWhite wrote…

test_nested_library_call fails due to a difference in ExecutionResources when comparing the CallInfo to the expected. The expected CallInfo is the same between the VM and Native. Eventually, these should be the same (right?), but for now it fails. How would you like me to address this? I could change the test to ignore ExecutionResources in the comparison for now, or mark the test as #[ignored]

I think we can just ignore ExecutionResources check while running Native test

---

[github-actions]

Artifacts upload triggered. View details here

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.14%. Comparing base (e3165c4) to head (2de1599).
Report is 405 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1547       +/-   ##
===========================================
+ Coverage   40.10%   69.14%   +29.03%     
===========================================
  Files          26      105       +79     
  Lines        1895    13709    +11814     
  Branches     1895    13709    +11814     
===========================================
+ Hits          760     9479     +8719     
- Misses       1100     3827     +2727     
- Partials       35      403      +368     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[PearsonWhite]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @varex83)

a discussion (no related file):

Previously, varex83 (Bohdan Ohorodnii) wrote…

I think we can just ignore ExecutionResources check while running Native test

I changed this so our expected_call_info uses the execution resources that are currently being used. This will fail when the gas is changed as long as the gas change is done correctly. At that point, the logic for if_native can be removed and the execution resources can be made the same.

---

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[meship-starkware]

Reviewed 1 of 2 files at r9, 2 of 2 files at r10, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @noaov1 and @varex83)

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[avi-starkware]

Reviewed 1 of 2 files at r10, 1 of 1 files at r11, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @noaov1, @varex83, and @Yoni-Starkware)

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[Yoni-Starkware]

Reviewed 2 of 2 files at r13, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @noaov1 and @varex83)

[Yoni-Starkware]

Dismissed @noaov1 from a discussion.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @noaov1 and @varex83)

OOO

[Yoni-Starkware]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @noaov1 and @varex83)

---

crates/blockifier/src/execution/native/syscall_handler.rs line 197 at r6 (raw file):

Previously, PearsonWhite wrote…

I think it's fine like this for now. I expect the error handling for StarknetSyscallHandler to change, and when that happens the return value for execute_inner_call will probably change as well.

.

[Yoni-Starkware]

Dismissed @noaov1 from a discussion.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @noaov1 and @varex83)

[Yoni-Starkware]

Dismissed @noaov1 from a discussion.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @noaov1 and @varex83)

[Yoni-Starkware]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @noaov1 and @varex83)

[Yoni-Starkware]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @noaov1 and @varex83)

---

crates/blockifier/src/execution/syscalls/syscall_tests/library_call.rs line 201 at r7 (raw file):

Previously, PearsonWhite wrote…

I forgot to git add this change on the previous update. It should be fixed now.

.

[Yoni-Starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noaov1 and @varex83)

---

crates/blockifier/src/execution/syscalls/syscall_tests/library_call.rs line 188 at r7 (raw file):

Previously, PearsonWhite wrote…

It looks like we do account for VM resources in native execution. For example in crates/blockifier/src/execution/entry_point_execution.rs::finalize_execution which get called during the tests.

.

[Yoni-Starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @varex83)