-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(execution): share enable_reverts check #1494
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware, @noaov1, and @Yoni-Starkware)
crates/blockifier/src/execution/entry_point_execution.rs
line 108 at r1 (raw file):
program_extra_data_length, tracked_resource, )?)
same return type
Suggestion:
finalize_execution(
runner,
syscall_handler,
previous_resources,
n_total_args,
program_extra_data_length,
tracked_resource,
)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1494 +/- ##
==========================================
- Coverage 74.18% 69.75% -4.44%
==========================================
Files 359 96 -263
Lines 36240 13104 -23136
Branches 36240 13104 -23136
==========================================
- Hits 26886 9141 -17745
+ Misses 7220 3563 -3657
+ Partials 2134 400 -1734
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware, @noaov1, and @Yoni-Starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware and @noaov1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware and @noaov1)
crates/blockifier/src/execution/entry_point_execution.rs
line 108 at r1 (raw file):
Previously, dorimedini-starkware wrote…
same return type
It's not, it returns PostExecutionError
, which is tachles more specific
No description provided.