Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(execution): share enable_reverts check #1494

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

Yoni-Starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware, @noaov1, and @Yoni-Starkware)


crates/blockifier/src/execution/entry_point_execution.rs line 108 at r1 (raw file):

        program_extra_data_length,
        tracked_resource,
    )?)

same return type

Suggestion:

    finalize_execution(
        runner,
        syscall_handler,
        previous_resources,
        n_total_args,
        program_extra_data_length,
        tracked_resource,
    )

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 69.75%. Comparing base (b0cfe82) to head (5808912).
Report is 450 commits behind head on main.

Files with missing lines Patch % Lines
...fier/src/execution/native/entry_point_execution.rs 0.00% 3 Missing ⚠️
.../blockifier/src/execution/entry_point_execution.rs 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1494      +/-   ##
==========================================
- Coverage   74.18%   69.75%   -4.44%     
==========================================
  Files         359       96     -263     
  Lines       36240    13104   -23136     
  Branches    36240    13104   -23136     
==========================================
- Hits        26886     9141   -17745     
+ Misses       7220     3563    -3657     
+ Partials     2134      400    -1734     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware, @noaov1, and @Yoni-Starkware)

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware and @noaov1)

Copy link
Collaborator Author

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware and @noaov1)


crates/blockifier/src/execution/entry_point_execution.rs line 108 at r1 (raw file):

Previously, dorimedini-starkware wrote…

same return type

It's not, it returns PostExecutionError, which is tachles more specific

@Yoni-Starkware Yoni-Starkware merged commit 20a60f6 into main Oct 21, 2024
12 checks passed
@Yoni-Starkware Yoni-Starkware deleted the yoni/ep/share-revert-check branch October 21, 2024 11:29
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants