Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(blockifier, starknet_api): delete blockifier's StarknetVersion #1378

Merged
merged 1 commit into from
Oct 15, 2024

refactor(blockifier, starknet_api): delete blockifier's StarknetVersion

932542f
Select commit
Loading
Failed to load commit list.
Merged

refactor(blockifier, starknet_api): delete blockifier's StarknetVersion #1378

refactor(blockifier, starknet_api): delete blockifier's StarknetVersion
932542f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 15, 2024 in 0s

62.58% (-11.61%) compared to b0cfe82

View this Pull Request on Codecov

62.58% (-11.61%) compared to b0cfe82

Details

Codecov Report

Attention: Patch coverage is 70.73171% with 12 lines in your changes missing coverage. Please review.

Project coverage is 62.58%. Comparing base (b0cfe82) to head (932542f).
Report is 425 commits behind head on main.

Files with missing lines Patch % Lines
crates/blockifier/src/versioned_constants.rs 77.41% 7 Missing ⚠️
crates/starknet_api/src/block.rs 0.00% 3 Missing ⚠️
crates/native_blockifier/src/lib.rs 0.00% 1 Missing ⚠️
crates/papyrus_execution/src/lib.rs 83.33% 0 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (b0cfe82) and HEAD (932542f). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (b0cfe82) HEAD (932542f)
3 1
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #1378       +/-   ##
===========================================
- Coverage   74.18%   62.58%   -11.61%     
===========================================
  Files         359      181      -178     
  Lines       36240    20332    -15908     
  Branches    36240    20332    -15908     
===========================================
- Hits        26886    12724    -14162     
+ Misses       7220     6679      -541     
+ Partials     2134      929     -1205

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov