feat(starknet_api): the StarknetVersion type is now an enum

[dorimedini-starkware]

This change is 

[dorimedini-starkware]

• refactor(execution): delete starknet version string constants and usages #1382
• refactor(blockifier, starknet_api): delete blockifier's StarknetVersion #1378
• feat(starknet_api): the StarknetVersion type is now an enum #1376 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dorimedini-starkware and the rest of your teammates on Graphite

[codecov]

Codecov Report

Attention: Patch coverage is 86.95652% with 3 lines in your changes missing coverage. Please review.

Project coverage is 71.46%. Comparing base (b0cfe82) to head (2a06947).
Report is 420 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/starknet_api/src/block.rs	85.71%	1 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1376      +/-   ##
==========================================
- Coverage   74.18%   71.46%   -2.73%     
==========================================
  Files         359      357       -2     
  Lines       36240    38149    +1909     
  Branches    36240    38149    +1909     
==========================================
+ Hits        26886    27262     +376     
- Misses       7220     8770    +1550     
+ Partials     2134     2117      -17     

Flag	Coverage Δ
	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Yoni-Starkware]

Reviewed 5 of 8 files at r1, 1 of 2 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)

---

crates/starknet_api/src/block.rs line 135 at r3 (raw file):

    type Error = StarknetApiError;
    fn try_from(starknet_version: &str) -> Result<Self, StarknetApiError> {
        Self::try_from(starknet_version.to_string())

Does this return Vec<u8>?

Code quote:

to_string()

[dorimedini-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

---

crates/starknet_api/src/block.rs line 135 at r3 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Does this return Vec<u8>?

no, it returns the string-serialized version, e.g. "0.13.1"

[dorimedini-starkware]

Merge activity

• Oct 15, 1:32 PM EDT: A user started a stack merge that includes this pull request via Graphite.
• Oct 15, 1:33 PM EDT: A user merged this pull request with Graphite.