-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(transaction): add clone to declare tx #129
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @avi-starkware and @meship-starkware)
crates/blockifier/src/transaction/account_transaction.rs
line 66 at r1 (raw file):
/// Represents a paid Starknet transaction. #[derive(Debug, Clone)]
Please alphabetize
Code quote:
#[derive(Debug, Clone)]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @avi-starkware and @noaov1)
crates/blockifier/src/transaction/account_transaction.rs
line 66 at r1 (raw file):
Previously, noaov1 (Noa Oved) wrote…
Please alphabetize
Hey, I see we have a lot of unordered Ddirives. Would you like me to fix this PR and add a task to fix all drives in the repo? (it can be writing a script that does it)
d66bb5c
to
c4f2a36
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 4 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avi-starkware)
c4f2a36
to
cc8166f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avi-starkware)
This change is