Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(blockifier): update cairo native to 0.2.0-alpha.2 #1241

Merged
merged 3 commits into from
Oct 21, 2024
Merged

feat(blockifier): update cairo native to 0.2.0-alpha.2 #1241

merged 3 commits into from
Oct 21, 2024

Conversation

rodrigo-pino
Copy link
Contributor

@rodrigo-pino rodrigo-pino commented Oct 8, 2024 •
edited by alon-dotan-starkware
Loading

This change is Reviewable

@rodrigo-pino rodrigo-pino added the native integration Related with the integration of Cairo Native into the Blockifier label Oct 8, 2024
@rodrigo-pino rodrigo-pino changed the base branch from main to rdr/add-entry-point-execution October 8, 2024 02:48
@rodrigo-pino rodrigo-pino force-pushed the rdr/use-native-crate-release branch 2 times, most recently from 2cfbd77 to a168b7e Compare October 8, 2024 02:59
@rodrigo-pino rodrigo-pino force-pushed the rdr/add-entry-point-execution branch 2 times, most recently from 2f4d0d2 to 075b835 Compare October 10, 2024 14:50
@rodrigo-pino rodrigo-pino force-pushed the rdr/use-native-crate-release branch from 48f603c to 0b5c809 Compare October 10, 2024 15:02
@github-actions GitHub Actions
Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [35.047 ms 35.098 ms 35.154 ms]
change: [-4.6976% -3.5658% -2.4923%] (p = 0.00 < 0.05)
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
3 (3.00%) high mild
1 (1.00%) high severe

noaov1
noaov1 approved these changes Oct 13, 2024
View reviewed changes
Copy link
Collaborator

@noaov1 noaov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r2, 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @alon-dotan-starkware)

avi-starkware
avi-starkware approved these changes Oct 13, 2024
View reviewed changes
Copy link
Contributor

@avi-starkware avi-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r2, 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @alon-dotan-starkware)

@rodrigo-pino rodrigo-pino force-pushed the rdr/add-entry-point-execution branch from 3e9210b to edde72b Compare October 14, 2024 03:42
@rodrigo-pino rodrigo-pino force-pushed the rdr/use-native-crate-release branch from 0b5c809 to adb1565 Compare October 14, 2024 03:52
@github-actions GitHub Actions
Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.684 ms 34.725 ms 34.768 ms]
change: [-6.6867% -4.3082% -2.1948%] (p = 0.00 < 0.05)
Performance has improved.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild

noaov1
noaov1 approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@noaov1 noaov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r5, 1 of 1 files at r7, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @alon-dotan-starkware)

@rodrigo-pino rodrigo-pino force-pushed the rdr/use-native-crate-release branch from adb1565 to 0b7b206 Compare October 16, 2024 00:36
@codecov Codecov
Copy link

codecov bot commented Oct 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.86%. Comparing base (b0cfe82) to head (11ed8b4).
Report is 457 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1241      +/-   ##
==========================================
+ Coverage   74.18%   75.86%   +1.67%     
==========================================
  Files         359      361       +2     
  Lines       36240    38465    +2225     
  Branches    36240    38465    +2225     
==========================================
+ Hits        26886    29182    +2296     
+ Misses       7220     7072     -148     
- Partials     2134     2211      +77
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PearsonWhite PearsonWhite force-pushed the rdr/use-native-crate-release branch from d879fd2 to 0b7b206 Compare October 16, 2024 12:57
@rodrigo-pino rodrigo-pino force-pushed the rdr/add-entry-point-execution branch from 67c4e9c to 76f983f Compare October 16, 2024 13:16
@rodrigo-pino rodrigo-pino force-pushed the rdr/use-native-crate-release branch from 0b7b206 to 8c17d0a Compare October 17, 2024 01:50
@github-actions GitHub Actions
Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.988 ms 35.015 ms 35.046 ms]
change: [-4.8112% -3.3059% -1.9069%] (p = 0.00 < 0.05)
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
2 (2.00%) high mild
2 (2.00%) high severe

@rodrigo-pino rodrigo-pino force-pushed the rdr/use-native-crate-release branch from 8c17d0a to ee6f0e4 Compare October 17, 2024 02:31
@github-actions GitHub Actions
Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [33.991 ms 34.017 ms 34.046 ms]
change: [-6.5945% -5.0041% -3.5227%] (p = 0.00 < 0.05)
Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
3 (3.00%) high mild
3 (3.00%) high severe

noaov1
noaov1 approved these changes Oct 20, 2024
View reviewed changes
Copy link
Collaborator

@noaov1 noaov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r8, 1 of 1 files at r10, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @alon-dotan-starkware)

@noaov1 noaov1 changed the base branch from rdr/add-entry-point-execution to main October 21, 2024 07:12
@rodrigo-pino rodrigo-pino force-pushed the rdr/use-native-crate-release branch 2 times, most recently from d34fad8 to dd666e3 Compare October 21, 2024 11:01
@rodrigo-pino rodrigo-pino force-pushed the rdr/use-native-crate-release branch from dd666e3 to 11ed8b4 Compare October 21, 2024 12:15
noaov1
noaov1 approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@noaov1 noaov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r11, 1 of 1 files at r13, 1 of 1 files at r16, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @alon-dotan-starkware)

@noaov1 noaov1 merged commit 6b8ae3a into main Oct 21, 2024
24 checks passed
@noaov1 noaov1 deleted the rdr/use-native-crate-release branch October 21, 2024 13:46
guy-starkware pushed a commit that referenced this pull request Oct 22, 2024
@rodrigo-pino @guy-starkware
feat(blockifier): update cairo native to 0.2.0-alpha.2 (#1241)
673b450 
* feat: update cairo native to 0.2.0-alpha.2

* chore: update script to install llvm-19

* chore: bump mac os llvm install to v19
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@noaov1 noaov1 noaov1 approved these changes

@avi-starkware avi-starkware avi-starkware approved these changes

@alon-dotan-starkware alon-dotan-starkware Awaiting requested review from alon-dotan-starkware

Assignees
No one assigned
Labels
native integration Related with the integration of Cairo Native into the Blockifier
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rodrigo-pino @avi-starkware @noaov1