build(fee): add l2_gas field to gas vector

[nimrod-starkware]

Pull Request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no API changes)
• Build-related changes
• Documentation content changes
• Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

• Yes
• No

Other information

---

This change is 

[nimrod-starkware]

python side PR

Reviewable status: 0 of 8 files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

[dorimedini-starkware]

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @nimrod-starkware)

---

crates/blockifier/src/fee/actual_cost_test.rs line 276 at r1 (raw file):

            .get_state_changes_cost(use_kzg_da)
            .l1_data_gas,
        ..Default::default()

indent

Suggestion:

    ..Default::default()

---

crates/blockifier/src/transaction/transactions_test.rs line 1869 at r1 (raw file):

    // (currently matches only starknet resources).
    let expected_gas = match use_kzg_da {
        true => GasVector { l1_gas: 16023, l1_data_gas: 128, ..Default::default() },

being explicit makes more sense here IMO

Suggestion:

, l2_gas: 0

[nimrod-starkware]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware)

---

crates/blockifier/src/fee/actual_cost_test.rs line 276 at r1 (raw file):

Previously, dorimedini-starkware wrote…

indent

The auto formatter keeps it that way; the .,Default::default() refers to l2_gas which is at the indentation level as the other fields in GasVector

---

crates/blockifier/src/transaction/transactions_test.rs line 1869 at r1 (raw file):

Previously, dorimedini-starkware wrote…

being explicit makes more sense here IMO

Done.

[dorimedini-starkware]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware)

a discussion (no related file):
blocking until python side passes..

---

---

crates/blockifier/src/fee/actual_cost_test.rs line 276 at r1 (raw file):

Previously, nimrod-starkware wrote…

The auto formatter keeps it that way; the .,Default::default() refers to l2_gas which is at the indentation level as the other fields in GasVector

ah! right you are

[codecov]

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.87%. Comparing base (fe93a3b) to head (2162307).
Report is 31 commits behind head on main.

Files	Patch %	Lines
crates/blockifier/src/transaction/objects.rs	66.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
- Coverage   76.89%   76.87%   -0.03%     
==========================================
  Files         316      316              
  Lines       34504    34517      +13     
  Branches    34504    34517      +13     
==========================================
+ Hits        26532    26534       +2     
- Misses       5687     5696       +9     
- Partials     2285     2287       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nimrod-starkware]

Reviewable status: 7 of 8 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)

a discussion (no related file):

Previously, dorimedini-starkware wrote…

blocking until python side passes..

hodor passed

---

[dorimedini-starkware]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)