Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workaround for lint_groups_priority issue #109

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

dorimedini-starkware
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware commented Jul 25, 2024

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information


This change is Reviewable

Copy link
Collaborator

@noaov1 noaov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r1, 2 of 3 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aner-starkware, @dafnamatsry, @dan-starkware, @dorimedini-starkware, and @TzahiTaub)


crates/blockifier/src/lib.rs line 9 at r3 (raw file):

    target_pointer_width = "32",
    target_pointer_width = "64",
    target_pointer_width = "128"

Why was it added?

Code quote:

    target_pointer_width = "128"

@dorimedini-starkware dorimedini-starkware merged commit a9dc431 into main-v0.13.2 Jul 25, 2024
14 of 15 checks passed
@dorimedini-starkware dorimedini-starkware deleted the dori/fix-clippy branch July 25, 2024 14:14
@github-actions github-actions bot locked and limited conversation to collaborators Jul 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants