chore: align the tx_hash parameter in the account tx creator test util #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 29, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ArniStarkware and the rest of your teammates on |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1073 +/- ##
===========================================
+ Coverage 40.10% 67.28% +27.18%
===========================================
Files 26 102 +76
Lines 1895 13701 +11806
Branches 1895 13701 +11806
===========================================
+ Hits 760 9219 +8459
- Misses 1100 4081 +2981
- Partials 35 401 +366 ☔ View full report in Codecov by Sentry. |
ArniStarkware
force-pushed
the
arni/test_utils/tx_creator/align_tx_hash_on_account_tx_creator
branch
from
bd7724b to
f74d1b4
Compare
|
Artifacts upload triggered. View details here |
MohammadNassar1
approved these changes
Oct 27, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Yael-Starkware)
ArniStarkware
deleted the
arni/test_utils/tx_creator/align_tx_hash_on_account_tx_creator
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is