feat(ci): deny rust warnings in all workflows (#2388)

Signed-off-by: Dori Medini <[email protected]>

.github/workflows/blockifier_ci.yml

@@ -34,6 +34,9 @@ on:
       - 'scripts/install_build_tools.sh'
       - 'scripts/sequencer-ci.Dockerfile'
 
+env:
+  RUSTFLAGS: "-D warnings"
+
 # On PR events, cancel existing CI runs on this same PR for this workflow.
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}-${{ github.job }}

.github/workflows/blockifier_compiled_cairo.yml

@@ -15,6 +15,9 @@ on:
       - 'crates/blockifier/tests/requirements.txt'
       - 'scripts/dependencies.sh'
 
+env:
+  RUSTFLAGS: "-D warnings"
+
 # On PR events, cancel existing CI runs on this same PR for this workflow.
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}-${{ github.job }}

.github/workflows/blockifier_reexecution_ci.yml

@@ -19,6 +19,9 @@ on:
       - 'scripts/install_build_tools.sh'
       - 'scripts/sequencer-ci.Dockerfile'
 
+env:
+  RUSTFLAGS: "-D warnings"
+
 # On PR events, cancel existing CI runs on this same PR for this workflow.
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}-${{ github.job }}

.github/workflows/committer_ci.yml

@@ -18,6 +18,9 @@ on:
       - 'crates/starknet_patricia/**'
       - 'scripts/dependencies.sh'
 
+env:
+  RUSTFLAGS: "-D warnings"
+
 # On PR events, cancel existing CI runs on this same PR for this workflow.
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}-${{ github.job }}

.github/workflows/committer_cli_push.yml

@@ -34,6 +34,9 @@ on:
       - 'crates/starknet_patricia/**'
       - 'scripts/dependencies.sh'
 
+env:
+  RUSTFLAGS: "-D warnings"
+
 # On PR events, cancel existing CI runs on this same PR for this workflow.
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}-${{ github.job }}

.github/workflows/main.yml

@@ -18,6 +18,7 @@ on:
 
 env:
   CI: 1
+  RUSTFLAGS: "-D warnings"
 
 # On PR events, cancel existing CI runs on this same PR for this workflow.
 concurrency:

.github/workflows/main_pr.yml

@@ -9,6 +9,9 @@ on:
       - auto_merge_enabled
       - edited
 
+env:
+  RUSTFLAGS: "-D warnings"
+
 # On PR events, cancel existing CI runs on this same PR for this workflow.
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}-${{ github.job }}

.github/workflows/papyrus_ci.yml

@@ -22,6 +22,9 @@ on:
   merge_group:
     types: [checks_requested]
 
+env:
+  RUSTFLAGS: "-D warnings"
+
 # On PR events, cancel existing CI runs on this same PR for this workflow.
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}-${{ github.job }}

.github/workflows/papyrus_docker-publish.yml

@@ -28,6 +28,7 @@ concurrency:
 env:
   REGISTRY: ghcr.io
   REPO_NAME: ${{ github.repository }}
+  RUSTFLAGS: "-D warnings"
 
 jobs:
   docker-build-push:

.github/workflows/papyrus_nightly-tests-call.yml

@@ -16,6 +16,9 @@ on:
       SLACK_ALERT_CHANNEL:
         required: true
 
+env:
+  RUSTFLAGS: "-D warnings"
+
 jobs:
   GW-integration-test-call:
     runs-on: ${{ inputs.os }}

.github/workflows/papyrus_nightly-tests.yml

@@ -6,6 +6,9 @@ on:
     - cron: '30 0 * * *'  # Uses macos runner.
   workflow_dispatch:  # Uses ubuntu runner.
 
+env:
+  RUSTFLAGS: "-D warnings"
+
 jobs:
   GW-integration-test-ubuntu:
     uses: ./.github/workflows/papyrus_nightly-tests-call.yml

.github/workflows/upload_artifacts_workflow.yml

@@ -5,6 +5,9 @@ on:
     workflows: [Trigger-Workflow]
     types: [completed]
 
+env:
+  RUSTFLAGS: "-D warnings"
+
 jobs:
   native-blockifier-artifacts-push:
     runs-on: starkware-ubuntu-20-04-medium

.github/workflows/verify-deps.yml

@@ -4,6 +4,9 @@ on:
   schedule:
     - cron: '0 0 * * *' # Runs at 00:00 UTC every day
 
+env:
+  RUSTFLAGS: "-D warnings"
+
 jobs:
   latest_deps:
     name: Latest Dependencies

crates/blockifier/src/execution/native/syscall_handler.rs

@@ -30,11 +30,7 @@ use crate::execution::entry_point::{CallEntryPoint, CallType, EntryPointExecutio
 use crate::execution::errors::EntryPointExecutionError;
 use crate::execution::native::utils::{calculate_resource_bounds, default_tx_v2_info};
 use crate::execution::secp;
-use crate::execution::syscalls::hint_processor::{
-    SyscallExecutionError,
-    INVALID_INPUT_LENGTH_ERROR,
-    OUT_OF_GAS_ERROR,
-};
+use crate::execution::syscalls::hint_processor::{SyscallExecutionError, OUT_OF_GAS_ERROR};
 use crate::execution::syscalls::syscall_base::SyscallHandlerBase;
 use crate::state::state_api::State;
 use crate::transaction::objects::TransactionInfo;