Skip to content

Commit

Permalink
chore: remove unnecessary async from create_http_server_config (#2960)
Browse files Browse the repository at this point in the history
* feat: add remote connection test

commit-id:819513bb

* chore: rename create_config function

commit-id:9b08c150

* chore: remove unnecessary async from create_http_server_config

commit-id:70994d75
  • Loading branch information
nadin-Starkware authored Dec 29, 2024
1 parent ad6a841 commit b79afdc
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion crates/starknet_http_server/src/test_utils.rs
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,6 @@ impl HttpTestClient {
}
}

pub async fn create_http_server_config(socket: SocketAddr) -> HttpServerConfig {
pub fn create_http_server_config(socket: SocketAddr) -> HttpServerConfig {
HttpServerConfig { ip: socket.ip(), port: socket.port() }
}
2 changes: 1 addition & 1 deletion crates/starknet_integration_tests/src/utils.rs
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ pub async fn create_node_config(
let batcher_config = create_batcher_config(batcher_storage_config, chain_info.clone());
let gateway_config = create_gateway_config(chain_info.clone()).await;
let http_server_config =
create_http_server_config(available_ports.get_next_local_host_socket()).await;
create_http_server_config(available_ports.get_next_local_host_socket());
let rpc_state_reader_config = test_rpc_state_reader_config(rpc_server_addr);
let monitoring_endpoint_config =
MonitoringEndpointConfig { port: available_ports.get_next_port(), ..Default::default() };
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ async fn setup(
create_batcher_config(storage_for_test.batcher_storage_config, chain_info.clone());
let gateway_config = create_gateway_config(chain_info).await;
let http_server_config =
create_http_server_config(available_ports.get_next_local_host_socket()).await;
create_http_server_config(available_ports.get_next_local_host_socket());
let rpc_state_reader_config = test_rpc_state_reader_config(rpc_server_addr);
let (mut network_configs, broadcast_channels) =
create_network_configs_connected_to_broadcast_channels::<RpcTransactionWrapper>(
Expand Down

0 comments on commit b79afdc

Please sign in to comment.