-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(sync): combine server channels #2247
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2247 +/- ##
==========================================
+ Coverage 66.34% 66.41% +0.06%
==========================================
Files 139 139
Lines 18379 18371 -8
Branches 18379 18371 -8
==========================================
+ Hits 12194 12201 +7
+ Misses 4890 4875 -15
Partials 1295 1295 ☔ View full report in Codecov by Sentry. |
6a41137
to
2e2ec9f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 10 of 11 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @eitanm-starkware)
crates/papyrus_network/src/network_manager/test.rs
line 295 at r2 (raw file):
select! { _ = async move { let SqmrServerPayload{query: query_got, report_sender: _report_sender, mut responses_sender} = inbound_payload_receiver.next().await.unwrap();
Space before {
I'm surprised CI didn't complain
crates/papyrus_p2p_sync/src/client/mod.rs
line 114 at r2 (raw file):
#[derive(thiserror::Error, Debug)] pub enum P2PClientSyncError {
Rename to P2PSyncClientError
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @eitanm-starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ShahakShama)
crates/papyrus_network/src/network_manager/test.rs
line 295 at r2 (raw file):
Previously, ShahakShama wrote…
Space before {
I'm surprised CI didn't complain
there is a space though
This change is