Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sync): combine server channels #2247

Closed
wants to merge 1 commit into from

Conversation

eitanm-starkware
Copy link
Contributor

@eitanm-starkware eitanm-starkware commented Jul 24, 2024

This change is Reviewable

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 70.70707% with 29 lines in your changes missing coverage. Please review.

Project coverage is 66.41%. Comparing base (3bcfcc6) to head (2e2ec9f).

Files Patch % Lines
crates/papyrus_node/src/main.rs 0.00% 18 Missing ⚠️
crates/papyrus_p2p_sync/src/client/mod.rs 0.00% 7 Missing ⚠️
crates/papyrus_p2p_sync/src/client/header.rs 50.00% 2 Missing ⚠️
...papyrus_network/src/peer_manager/behaviour_impl.rs 0.00% 1 Missing ⚠️
crates/papyrus_p2p_sync/src/server/mod.rs 97.43% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2247      +/-   ##
==========================================
+ Coverage   66.34%   66.41%   +0.06%     
==========================================
  Files         139      139              
  Lines       18379    18371       -8     
  Branches    18379    18371       -8     
==========================================
+ Hits        12194    12201       +7     
+ Misses       4890     4875      -15     
  Partials     1295     1295              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eitanm-starkware eitanm-starkware force-pushed the eitan/combine_server_channels branch from 6a41137 to 2e2ec9f Compare July 24, 2024 09:35
Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 11 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @eitanm-starkware)


crates/papyrus_network/src/network_manager/test.rs line 295 at r2 (raw file):

    select! {
        _ = async move {
            let SqmrServerPayload{query: query_got, report_sender: _report_sender, mut responses_sender} = inbound_payload_receiver.next().await.unwrap();

Space before {
I'm surprised CI didn't complain


crates/papyrus_p2p_sync/src/client/mod.rs line 114 at r2 (raw file):

#[derive(thiserror::Error, Debug)]
pub enum P2PClientSyncError {

Rename to P2PSyncClientError

Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @eitanm-starkware)

Copy link
Contributor Author

@eitanm-starkware eitanm-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ShahakShama)


crates/papyrus_network/src/network_manager/test.rs line 295 at r2 (raw file):

Previously, ShahakShama wrote…

Space before {
I'm surprised CI didn't complain

there is a space though

@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants