Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert(network): remove send_query from streamed bytes #2246

Closed
wants to merge 1 commit into from

Conversation

ShahakShama
Copy link
Contributor

@ShahakShama ShahakShama commented Jul 23, 2024

This change is Reviewable

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 92.18750% with 5 lines in your changes missing coverage. Please review.

Project coverage is 66.50%. Comparing base (6403530) to head (623780d).

Files Patch % Lines
crates/papyrus_network/src/test_utils/mod.rs 91.83% 4 Missing ⚠️
crates/papyrus_network/src/sqmr/behaviour.rs 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2246      +/-   ##
==========================================
+ Coverage   66.35%   66.50%   +0.15%     
==========================================
  Files         139      139              
  Lines       18339    18348       +9     
  Branches    18339    18348       +9     
==========================================
+ Hits        12168    12202      +34     
+ Misses       4877     4850      -27     
- Partials     1294     1296       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ShahakShama ShahakShama force-pushed the shahak/SB_remove_send_query branch from a271b99 to 623780d Compare July 23, 2024 05:48
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant