fix(network): remove TryFrom for response from server payload #2244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShahakShama
force-pushed
the
eitan/remove_tryfrom_for_response_from_server
branch
from
d05b07a to
fa19ba9
Compare
ShahakShama
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @eitanm-starkware)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2244 +/- ##
==========================================
+ Coverage 66.33% 66.34% +0.01%
==========================================
Files 139 139
Lines 18346 18341 -5
Branches 18346 18341 -5
==========================================
Hits 12169 12169
+ Misses 4884 4879 -5
Partials 1293 1293 ☔ View full report in Codecov by Sentry. |
dan-starkware
pushed a commit
that referenced
this pull request
Jul 23, 2024
dan-starkware
pushed a commit
that referenced
this pull request
Jul 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is