Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(consensus): fix typo in state machine #2231

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

AlonLStarkWare
Copy link
Contributor

@AlonLStarkWare AlonLStarkWare commented Jul 16, 2024

This change is Reviewable

Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AlonLStarkWare)


-- commits line 2 at r1:
remove the " a "

@AlonLStarkWare AlonLStarkWare force-pushed the alon/fix_typo_in_state_machine branch from d4e4fd1 to 528fbcd Compare July 16, 2024 12:16
@AlonLStarkWare AlonLStarkWare changed the title chore(consensus): fix a typo in state machine chore(consensus): fix typo in state machine Jul 16, 2024
Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AlonLStarkWare)

@AlonLStarkWare AlonLStarkWare enabled auto-merge July 16, 2024 12:21
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.26%. Comparing base (40f8574) to head (528fbcd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2231   +/-   ##
=======================================
  Coverage   66.26%   66.26%           
=======================================
  Files         139      139           
  Lines       18338    18338           
  Branches    18338    18338           
=======================================
  Hits        12151    12151           
  Misses       4890     4890           
  Partials     1297     1297           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlonLStarkWare AlonLStarkWare added this pull request to the merge queue Jul 16, 2024
Merged via the queue into main with commit fa2d312 Jul 16, 2024
49 checks passed
@AlonLStarkWare AlonLStarkWare deleted the alon/fix_typo_in_state_machine branch July 16, 2024 12:31
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants