Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(network): conversion from SyncClientQueryForNetwork to SyncClient #2230

Merged
merged 1 commit into from
Jul 16, 2024
Merged

chore(network): conversion from SyncClientQueryForNetwork to SyncClient #2230

merged 1 commit into from
Jul 16, 2024

Conversation

eitanm-starkware
Copy link
Contributor

@eitanm-starkware eitanm-starkware commented Jul 16, 2024 •
edited by spapinistarkware
Loading

This change is Reviewable

ShahakShama
ShahakShama approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @eitanm-starkware)

@codecov Codecov
Copy link

codecov bot commented Jul 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 66.25%. Comparing base (b348d9f) to head (c44dd08).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/papyrus_network/src/network_manager/mod.rs 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2230      +/-   ##
==========================================
- Coverage   66.31%   66.25%   -0.06%     
==========================================
  Files         139      139              
  Lines       18333    18338       +5     
  Branches    18333    18338       +5     
==========================================
- Hits        12157    12150       -7     
- Misses       4881     4890       +9     
- Partials     1295     1298       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ShahakShama
ShahakShama previously approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @eitanm-starkware)

@ShahakShama ShahakShama force-pushed the eitan/impl_from_queryfornetwork_to_query branch from 61d773c to 77c7586 Compare July 16, 2024 10:56
eitanm-starkware
eitanm-starkware commented Jul 16, 2024
View reviewed changes
Copy link
Contributor Author

@eitanm-starkware eitanm-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @ShahakShama)

@ShahakShama ShahakShama enabled auto-merge July 16, 2024 10:57
@ShahakShama ShahakShama force-pushed the eitan/impl_from_queryfornetwork_to_query branch from 77c7586 to b7ba88f Compare July 16, 2024 11:14
eitanm-starkware
eitanm-starkware commented Jul 16, 2024
View reviewed changes
Copy link
Contributor Author

@eitanm-starkware eitanm-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @ShahakShama)

ShahakShama
ShahakShama previously approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @eitanm-starkware)

@ShahakShama ShahakShama force-pushed the eitan/impl_from_queryfornetwork_to_query branch from b7ba88f to c44dd08 Compare July 16, 2024 11:17
ShahakShama
ShahakShama approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @eitanm-starkware)

@ShahakShama ShahakShama added this pull request to the merge queue Jul 16, 2024
Merged via the queue into main with commit 40f8574 Jul 16, 2024
19 checks passed
@ShahakShama ShahakShama deleted the eitan/impl_from_queryfornetwork_to_query branch July 16, 2024 11:28
asmaastarkware pushed a commit that referenced this pull request Jul 17, 2024
@eitanm-starkware @asmaastarkware
chore(network): conversion from SyncClientQueryForNetwork to SyncClie…
997c29c 
…nt (#2230)

chore(network): conversion from SyncClientQueryForNetwork to SyncClientQuery
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ShahakShama ShahakShama ShahakShama approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eitanm-starkware @ShahakShama