Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sync): add p2p sync server logs #2221

Closed
wants to merge 1 commit into from

Conversation

ShahakShama
Copy link
Contributor

@ShahakShama ShahakShama commented Jul 15, 2024

This change is Reviewable

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 66.26%. Comparing base (b1e0bdc) to head (d80f9c5).
Report is 5 commits behind head on main.

Files Patch % Lines
crates/papyrus_p2p_sync/src/server/mod.rs 0.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2221      +/-   ##
==========================================
+ Coverage   65.80%   66.26%   +0.46%     
==========================================
  Files         139      139              
  Lines       18308    18316       +8     
  Branches    18308    18316       +8     
==========================================
+ Hits        12047    12138      +91     
+ Misses       4968     4879      -89     
- Partials     1293     1299       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@eitanm-starkware eitanm-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @dan-starkware and @ShahakShama)


crates/papyrus_p2p_sync/src/server/mod.rs line 207 at r1 (raw file):

        P2PSyncServerError: From<<Sender as Sink<DataOrFin<Data>>>::Error>,
    {
        info!("Got a new inbound query {query:?}");

server received a new..?


crates/papyrus_p2p_sync/src/server/mod.rs line 405 at r1 (raw file):

    // If this function fails, we still want to send fin before failing.
    let result = send_data_without_fin_for_query(&storage_reader, query, &mut sender).await;
    info!("Sending fin message");

Sending fin message to inbound query?


crates/papyrus_p2p_sync/src/server/mod.rs line 437 at r1 (raw file):

        for data in data_vec {
            // TODO: consider implement retry mechanism.
            info!("Sending data");

Responding to inbound query?

@ShahakShama ShahakShama force-pushed the shahak/p2p_sync_server_logs branch from da04765 to d80f9c5 Compare July 16, 2024 05:00
Copy link
Contributor Author

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, 3 unresolved discussions (waiting on @dan-starkware and @eitanm-starkware)


crates/papyrus_p2p_sync/src/server/mod.rs line 207 at r1 (raw file):

Previously, eitanm-starkware wrote…

server received a new..?

Done.


crates/papyrus_p2p_sync/src/server/mod.rs line 405 at r1 (raw file):

Previously, eitanm-starkware wrote…

Sending fin message to inbound query?

Done.


crates/papyrus_p2p_sync/src/server/mod.rs line 437 at r1 (raw file):

Previously, eitanm-starkware wrote…

Responding to inbound query?

Done.

Copy link
Contributor

@eitanm-starkware eitanm-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @dan-starkware)

@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants