-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helm): add support to p2p #2212
Conversation
7207a73
to
f743fd4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2212 +/- ##
==========================================
- Coverage 66.23% 66.23% -0.01%
==========================================
Files 139 139
Lines 18343 18343
Branches 18343 18343
==========================================
- Hits 12150 12149 -1
Misses 4895 4895
- Partials 1298 1299 +1 ☔ View full report in Codecov by Sentry. |
1ce7dda
to
265b6c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: 2 of 6 files reviewed, all discussions resolved
9ddd9ad
to
1dc1db8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: 1 of 6 files reviewed, 2 unresolved discussions (waiting on @idan-starkware)
deployments/helm/values.yaml
line 11 at r5 (raw file):
# Ethereum node URL. A value for this variable is mandatory. base_layer_node_url: https://base_url.example.com
this config field shouldn't get a default value because there is no default value that will work globally.
deployments/helm/values.yaml
line 96 at r5 (raw file):
pvc: # Recommended size is at least 512Gi. size: 1Gi
as discussed verbally yesterday, either set the recommended size or don't set a size at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 6 files reviewed, 2 unresolved discussions (waiting on @eranreshef-starkware and @idan-starkware)
deployments/helm/values.yaml
line 11 at r5 (raw file):
Previously, eranreshef-starkware (Eran Reshef) wrote…
this config field shouldn't get a default value because there is no default value that will work globally.
Done.
deployments/helm/values.yaml
line 96 at r5 (raw file):
Previously, eranreshef-starkware (Eran Reshef) wrote…
as discussed verbally yesterday, either set the recommended size or don't set a size at all.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 6 files at r1, 1 of 2 files at r4, 1 of 1 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @idan-starkware)
b4cb458
to
4320c60
Compare
This change is