-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(storage): use common file handler #1281
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1281 +/- ##
==========================================
+ Coverage 72.96% 72.99% +0.02%
==========================================
Files 84 84
Lines 7968 7972 +4
Branches 7968 7972 +4
==========================================
+ Hits 5814 5819 +5
- Misses 1228 1229 +1
+ Partials 926 924 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dan-starkware)
crates/papyrus_storage/src/mmap_file/mod.rs
line 102 at r1 (raw file):
/// A wrapper around `MMapFile` that provides both write and read interfaces. #[derive(Clone, Debug)] pub struct FileHandler<V: StorageSerde> {
I think this struct should be private (and move down in the file, maybe even into a module)
Code quote:
pub
0a886a0
to
50740f3
Compare
f740416
to
ca10986
Compare
ca10986
to
f5c9e6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @yair-starkware)
crates/papyrus_storage/src/mmap_file/mod.rs
line 102 at r1 (raw file):
Previously, yair-starkware (Yair) wrote…
I think this struct should be private (and move down in the file, maybe even into a module)
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dan-starkware)
crates/papyrus_storage/src/mmap_file/mod.rs
line 143 at r3 (raw file):
/// Represents a memory mapped append only file. #[derive(Debug)] pub struct MMapFile<V: StorageSerde> {
Private too?
Code quote:
pub
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yair-starkware)
crates/papyrus_storage/src/mmap_file/mod.rs
line 143 at r3 (raw file):
Previously, yair-starkware (Yair) wrote…
Private too?
Sure in the next PR
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this introduce a breaking change?
Other information
This change is