Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(JSON-RPC): get_class supports pending #1278

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

ShahakShama
Copy link
Contributor

@ShahakShama ShahakShama commented Oct 16, 2023

This change is Reviewable

Copy link
Contributor

@yair-starkware yair-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dan-starkware)

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

❗ No coverage uploaded for pull request base (rpc_pending@855a472). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             rpc_pending    #1278   +/-   ##
==============================================
  Coverage               ?   73.12%           
==============================================
  Files                  ?       84           
  Lines                  ?     8122           
  Branches               ?     8122           
==============================================
  Hits                   ?     5939           
  Misses                 ?     1221           
  Partials               ?      962           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ShahakShama ShahakShama force-pushed the shahak/pending/get_class branch from 5e887c2 to ed17220 Compare October 17, 2023 13:12
Copy link
Contributor

@yair-starkware yair-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dan-starkware)

@ShahakShama ShahakShama merged commit 78c86bf into rpc_pending Oct 18, 2023
19 checks passed
@ShahakShama ShahakShama deleted the shahak/pending/get_class branch October 18, 2023 07:54
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants