Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storage): remove redundant clones #1277

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Conversation

dan-starkware
Copy link
Collaborator

@dan-starkware dan-starkware commented Oct 16, 2023

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information


This change is Reviewable

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #1277 (ae13495) into main (bf586b2) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #1277   +/-   ##
=======================================
  Coverage   72.99%   72.99%           
=======================================
  Files          84       84           
  Lines        7950     7950           
  Branches     7950     7950           
=======================================
  Hits         5803     5803           
  Misses       1224     1224           
  Partials      923      923           
Files Coverage Δ
crates/papyrus_storage/src/utils.rs 56.25% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dan-starkware dan-starkware marked this pull request as ready for review October 16, 2023 11:18
Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Yael-Starkware)

@dan-starkware dan-starkware added this pull request to the merge queue Oct 16, 2023
Merged via the queue into main with commit 32bf727 Oct 16, 2023
51 checks passed
@dan-starkware dan-starkware deleted the dan/storage/cargo-fix branch October 16, 2023 11:48
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants