test(JSON-RPC): send a slack alert upon GW integration test failure #1273
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1273 +/- ##
=======================================
Coverage 72.99% 72.99%
=======================================
Files 84 84
Lines 7951 7951
Branches 7951 7951
=======================================
Hits 5804 5804
Misses 1224 1224
Partials 923 923 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dan-starkware and @TzahiTaub)
a discussion (no related file):
is there a place where we can configure these 'secret' values which is not seen by outsiders?
TzahiTaub
force-pushed
the
tzahi/gw_integration_test_slack_alert
branch
from
59a248c to
66509ec
Compare
There was a problem hiding this comment.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @dan-starkware and @OmriEshhar1)
a discussion (no related file):
Previously, OmriEshhar1 wrote…
is there a place where we can configure these 'secret' values which is not seen by outsiders?
In the repo settings (can only be accessed by the owner/privileged ysers).
There was a problem hiding this comment.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @dan-starkware and @OmriEshhar1)
a discussion (no related file):
Previously, TzahiTaub (Tzahi) wrote…
In the repo settings (can only be accessed by the owner/privileged ysers).
The used secrets were already added
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dan-starkware)
TzahiTaub
force-pushed
the
tzahi/gw_integration_test_basic
branch
2 times, most recently
from
0c5f22d to
a104a6d
Compare
TzahiTaub
force-pushed
the
tzahi/gw_integration_test_slack_alert
branch
from
66509ec to
cd95620
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dan-starkware)
TzahiTaub
force-pushed
the
tzahi/gw_integration_test_slack_alert
branch
from
cd95620 to
fc6809f
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:
TzahiTaub
force-pushed
the
tzahi/gw_integration_test_slack_alert
branch
from
fc6809f to
ab6f7ac
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
gateway_integration_test failure fails the workflow with no alert.
What is the new behavior?
Does this introduce a breaking change?
Other information
This change is