fix(): run node without syncing

[yair-starkware]

Pull Request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no API changes)
• Build-related changes
• Documentation content changes
• Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

• Yes
• No

Other information

---

This change is 

[codecov]

Codecov Report

Merging #1242 (f4f2135) into main (2cf68ee) will decrease coverage by 0.02%.
The diff coverage is 11.53%.

@@            Coverage Diff             @@
##             main    #1242      +/-   ##
==========================================
- Coverage   71.05%   71.04%   -0.02%     
==========================================
  Files          83       83              
  Lines        7947     7949       +2     
  Branches     7947     7949       +2     
==========================================
  Hits         5647     5647              
- Misses       1390     1391       +1     
- Partials      910      911       +1     

Files	Coverage Δ
crates/papyrus_config/src/lib.rs	61.90% <ø> (ø)
crates/papyrus_config/src/presentation.rs	80.76% <75.00%> (-4.42%)	⬇️
crates/papyrus_node/src/main.rs	2.22% <0.00%> (-0.08%)	⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[eranreshef-starkware]

helm related changes lgtm

Reviewed 2 of 5 files at r1, all commit messages.
Reviewable status: 2 of 5 files reviewed, all discussions resolved (waiting on @dan-starkware, @DvirYo-starkware, and @yoavGrs)

[dan-starkware]

crates/papyrus_node/src/main.rs line 100 at r1 (raw file):

        storage_writer: StorageWriter,
    ) -> Result<(), StateSyncError> {
        let Some(sync_config) = config.sync else { return Ok(()) };

What about this?

Code quote:

 let Some(sync_config) = config.sync else { return Ok(()) };

[yair-starkware]

Reviewable status: 2 of 5 files reviewed, 1 unresolved discussion (waiting on @dan-starkware, @DvirYo-starkware, and @yoavGrs)

---

crates/papyrus_node/src/main.rs line 100 at r1 (raw file):

Previously, dan-starkware wrote…

What about this?

fixed

[dan-starkware]

Reviewed 4 of 5 files at r1, 2 of 2 files at r3.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @DvirYo-starkware and @yoavGrs)

---

crates/papyrus_config/src/presentation.rs line 22 at r3 (raw file):

    // Iterates over flatten param paths for removing non-public parameters from the nested config.
    // For example, for the param path 'a.b.c.d', perform config_presentation[a][b][c].remove(d).

Not related. please fix (d is private?)

Code quote:

/ For example, for the param path 'a.b.c.d', perform config_presentation[a][b][c].remove(d).

---

deployments/helm/templates/deployment.yaml line 65 at r3 (raw file):

        - --base_layer.node_url
        - {{ .Values.base_layer_node_url }}
        - --sync.#is_none

Not related. Please rename

Code quote:

--sync.#is_none

[dan-starkware]

Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @DvirYo-starkware and @yoavGrs)

[yoavGrs]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @DvirYo-starkware and @yair-starkware)

---

crates/papyrus_config/src/presentation.rs line 27 at r3 (raw file):

            ParamPrivacy::Public => continue,
            ParamPrivacy::Private => (),
            ParamPrivacy::TemporaryValue => continue,

Why continue on temporary value?

Code quote:

ParamPrivacy::TemporaryValue => continue,

[github-actions]

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!