Skip to content
This repository has been archived by the owner on Dec 26, 2024. It is now read-only.

fix(execution): remove validate invocation from invoke v0 trace #1238

Closed
wants to merge 2 commits into from

Conversation

yair-starkware
Copy link
Contributor

@yair-starkware yair-starkware commented Oct 3, 2023

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information


This change is Reviewable

@yair-starkware yair-starkware self-assigned this Oct 3, 2023
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #1238 (bfc87ee) into main (f711cec) will decrease coverage by 0.23%.
Report is 4 commits behind head on main.
The diff coverage is 59.84%.

@@            Coverage Diff             @@
##             main    #1238      +/-   ##
==========================================
- Coverage   72.04%   71.81%   -0.23%     
==========================================
  Files          78       80       +2     
  Lines        7622     7809     +187     
  Branches     7622     7809     +187     
==========================================
+ Hits         5491     5608     +117     
- Misses       1254     1302      +48     
- Partials      877      899      +22     
Files Coverage Δ
crates/papyrus_storage/src/lib.rs 59.20% <ø> (ø)
crates/papyrus_storage/src/serializers.rs 84.25% <100.00%> (+0.04%) ⬆️
crates/starknet_client/src/reader/objects/block.rs 87.50% <85.71%> (-0.26%) ⬇️
crates/papyrus_execution/src/execution_utils.rs 43.24% <0.00%> (-11.05%) ⬇️
crates/papyrus_common/src/block_hash.rs 84.74% <89.09%> (+1.56%) ⬆️
crates/papyrus_sync/src/lib.rs 70.40% <72.72%> (+0.63%) ⬆️
crates/papyrus_node/src/main.rs 2.40% <0.00%> (-0.41%) ⬇️
crates/papyrus_rpc/src/v0_4_0/api/mod.rs 50.00% <0.00%> (+0.81%) ⬆️
crates/papyrus_sync/src/sources/pending.rs 20.83% <20.83%> (ø)
crates/papyrus_storage/src/mmap_file/mod.rs 67.44% <67.44%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant