Skip to content
This repository has been archived by the owner on Dec 26, 2024. It is now read-only.

test(load_test): partially add execution and spec V0_4 scenario #1129

Merged
merged 3 commits into from
Sep 20, 2023

Conversation

DvirYo-starkware
Copy link
Contributor

@DvirYo-starkware DvirYo-starkware commented Sep 3, 2023

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information


This change is Reviewable

@codecov
Copy link

codecov bot commented Sep 3, 2023

Codecov Report

Merging #1129 (c3d13a3) into main (a9501a9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1129   +/-   ##
=======================================
  Coverage   71.43%   71.43%           
=======================================
  Files          77       77           
  Lines        7509     7509           
  Branches     7509     7509           
=======================================
  Hits         5364     5364           
  Misses       1246     1246           
  Partials      899      899           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@DvirYo-starkware DvirYo-starkware force-pushed the dvir/execution_to_lt_partial branch from 6bf81d2 to 4789d95 Compare September 10, 2023 09:42
Copy link
Collaborator

@dan-starkware dan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 5 files at r1, all commit messages.
Reviewable status: 4 of 5 files reviewed, all discussions resolved (waiting on @ShahakShama)


crates/papyrus_load_test/src/main.rs line 4 at r1 (raw file):

// first set the env variable VERSION_ID to the version of the node you want to test.
// To run this load test, run locally a node and then run:
//      cargo run -r -p papyrus_load_test -- -t 5m -H http://127.0.0.1:8080 --scenarios=generalrequestv004

Consider using v04 instead.
Also, please write the available scenarios.

Code quote:

 --scenarios=generalrequestv004

Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 5 files at r1, 1 of 1 files at r2, 2 of 2 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @DvirYo-starkware)

@DvirYo-starkware DvirYo-starkware added this pull request to the merge queue Sep 20, 2023
Merged via the queue into main with commit 4e1f495 Sep 20, 2023
@DvirYo-starkware DvirYo-starkware deleted the dvir/execution_to_lt_partial branch September 20, 2023 13:40
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants