Skip to content
This repository has been archived by the owner on Dec 26, 2024. It is now read-only.

style(storage): order the tables of the db #1128

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

DvirYo-starkware
Copy link
Contributor

@DvirYo-starkware DvirYo-starkware commented Sep 3, 2023

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information


This change is Reviewable

@codecov
Copy link

codecov bot commented Sep 3, 2023

Codecov Report

Merging #1128 (c39969e) into main (224b66a) will increase coverage by 0.01%.
Report is 14 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1128      +/-   ##
==========================================
+ Coverage   74.17%   74.19%   +0.01%     
==========================================
  Files          73       73              
  Lines        6642     6642              
  Branches     6642     6642              
==========================================
+ Hits         4927     4928       +1     
  Misses        873      873              
+ Partials      842      841       -1     
Files Changed Coverage Δ
crates/papyrus_storage/src/lib.rs 43.18% <0.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@DvirYo-starkware DvirYo-starkware added this pull request to the merge queue Sep 13, 2023
Copy link
Contributor

@yair-starkware yair-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ShahakShama)

Merged via the queue into main with commit 55db733 Sep 13, 2023
@DvirYo-starkware DvirYo-starkware deleted the dvir/order_db_tabels branch September 13, 2023 07:49
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants