Skip to content
This repository has been archived by the owner on Dec 26, 2024. It is now read-only.

chore(JSON-RPC,execution): consolidate repeating test code #1102

Merged
merged 1 commit into from
Sep 3, 2023

Conversation

yair-starkware
Copy link
Contributor

@yair-starkware yair-starkware commented Aug 24, 2023

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information


This change is Reviewable

@yair-starkware yair-starkware self-assigned this Aug 24, 2023
@yair-starkware yair-starkware force-pushed the yair/consolidate_trace_tests branch from 6980f38 to 3ca5a58 Compare August 24, 2023 09:58
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #1102 (f26af4b) into main (93be831) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #1102   +/-   ##
=======================================
  Coverage   74.19%   74.19%           
=======================================
  Files          73       73           
  Lines        6642     6642           
  Branches     6642     6642           
=======================================
  Hits         4928     4928           
  Misses        873      873           
  Partials      841      841           
Files Changed Coverage Δ
crates/papyrus_execution/src/objects.rs 40.80% <0.00%> (ø)
crates/papyrus_rpc/src/v0_4_0/api/mod.rs 44.58% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

dan-starkware
dan-starkware previously approved these changes Aug 31, 2023
Copy link
Collaborator

@dan-starkware dan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yair-starkware)

@yair-starkware yair-starkware added this pull request to the merge queue Aug 31, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 31, 2023
@yair-starkware yair-starkware added this pull request to the merge queue Sep 3, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 3, 2023
@yair-starkware yair-starkware added this pull request to the merge queue Sep 3, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 3, 2023
@yair-starkware
Copy link
Contributor Author

crates/papyrus_execution/src/objects.rs line 128 at r2 (raw file):

/// The execution trace of an L1Handler transaction.
#[derive(Clone, Debug, Serialize, Deserialize, Eq, PartialEq)]

I'm not sure why reviewable is showing this like a new code - I just added Eq + PartialEq to the derive

@yair-starkware yair-starkware added this pull request to the merge queue Sep 3, 2023
Copy link
Collaborator

@dan-starkware dan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yair-starkware)

Merged via the queue into main with commit b9aecf5 Sep 3, 2023
@yair-starkware yair-starkware deleted the yair/consolidate_trace_tests branch September 3, 2023 10:26
@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants