chore(config): add short consensus delay to prevent InsufficientPeers…

… error

config/default_config.json

@@ -79,6 +79,11 @@
     "privacy": "TemporaryValue",
     "value": true
   },
+  "consensus.consensus_delay": {
+    "description": "Delay (seconds) before starting consensus to give time for network peering.",
+    "privacy": "Public",
+    "value": 5
+  },
   "consensus.num_validators": {
     "description": "The number of validators in the consensus.",
     "privacy": "Public",

crates/papyrus_node/src/config/snapshots/papyrus_node__config__config_test__dump_default_config.snap

@@ -89,6 +89,13 @@ expression: dumped_default_config
     "value": true,
     "privacy": "TemporaryValue"
   },
+  "consensus.consensus_delay": {
+    "description": "Delay (seconds) before starting consensus to give time for network peering.",
+    "value": {
+      "$serde_json::private::Number": "5"
+    },
+    "privacy": "Public"
+  },
   "consensus.num_validators": {
     "description": "The number of validators in the consensus.",
     "value": {

crates/papyrus_node/src/main.rs

@@ -128,6 +128,7 @@ fn run_consensus(
         context,
         start_height,
         validator_id,
+        config.consensus_delay,
         consensus_channels.broadcasted_messages_receiver,
     )))
 }

crates/sequencing/papyrus_consensus/src/config.rs

@@ -3,7 +3,9 @@
 //! such as the validator ID, the network topic of the consensus, and the starting block height.
 
 use std::collections::BTreeMap;
+use std::time::Duration;
 
+use papyrus_config::converters::deserialize_seconds_to_duration;
 use papyrus_config::dumping::{ser_param, ser_required_param, SerializeConfig};
 use papyrus_config::{ParamPath, ParamPrivacyInput, SerializationType, SerializedParam};
 use serde::{Deserialize, Serialize};
@@ -23,6 +25,9 @@ pub struct ConsensusConfig {
     /// The number of validators in the consensus.
     // Used for testing in an early milestones.
     pub num_validators: u64,
+    /// The delay (seconds) before starting consensus to give time for network peering.
+    #[serde(deserialize_with = "deserialize_seconds_to_duration")]
+    pub consensus_delay: Duration,
 }
 
 impl SerializeConfig for ConsensusConfig {
@@ -52,6 +57,12 @@ impl SerializeConfig for ConsensusConfig {
                 "The number of validators in the consensus.",
                 ParamPrivacyInput::Public,
             ),
+            ser_param(
+                "consensus_delay",
+                &self.consensus_delay.as_secs(),
+                "Delay (seconds) before starting consensus to give time for network peering.",
+                ParamPrivacyInput::Public,
+            ),
         ])
     }
 }
@@ -63,6 +74,7 @@ impl Default for ConsensusConfig {
             topic: "consensus".to_string(),
             start_height: BlockNumber::default(),
             num_validators: 4,
+            consensus_delay: Duration::from_secs(5),
         }
     }
 }

crates/sequencing/papyrus_consensus/src/lib.rs

@@ -3,6 +3,8 @@
 // TODO(Matan): fix #[allow(missing_docs)].
 //! A consensus implementation for a [`Starknet`](https://www.starknet.io/) node.
 
+use std::time::Duration;
+
 use futures::channel::{mpsc, oneshot};
 use papyrus_common::metrics as papyrus_metrics;
 use papyrus_network::network_manager::BroadcastSubscriberReceiver;
@@ -106,12 +108,15 @@ pub async fn run_consensus<BlockT: ConsensusBlock, ContextT: ConsensusContext<Bl
     context: ContextT,
     start_height: BlockNumber,
     validator_id: ValidatorId,
+    consensus_delay: Duration,
     mut network_receiver: BroadcastSubscriberReceiver<ConsensusMessage>,
 ) -> Result<(), ConsensusError>
 where
     ProposalWrapper:
         Into<(ProposalInit, mpsc::Receiver<BlockT::ProposalChunk>, oneshot::Receiver<BlockHash>)>,
 {
+    // Add a short delay to allow peers to connect and avoid "InsufficientPeers" error
+    tokio::time::sleep(consensus_delay).await;
     let mut current_height = start_height;
     let mut future_messages = Vec::new();
     loop {