test(mempool): mempool state empty func #530
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #530 +/- ##
=======================================
Coverage 81.21% 81.21%
=======================================
Files 42 42
Lines 1826 1826
Branches 1826 1826
=======================================
Hits 1483 1483
Misses 269 269
Partials 74 74 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ayeletstarkware)
crates/mempool/src/mempool_test.rs line 39 at r1 (raw file):
// TODO(Ayelet): Use in all relevant tests. fn empty() -> Self {
WDYT of Default separately forMempoolState<[FullState/PartialState]>?
I know we deleted it, but it was for MempoolState<T>, which was less intuitive IMO.
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @elintul)
crates/mempool/src/mempool_test.rs line 39 at r1 (raw file):
Previously, elintul (Elin) wrote…
WDYT of
Defaultseparately forMempoolState<[FullState/PartialState]>?
I know we deleted it, but it was forMempoolState<T>, which was less intuitive IMO.
it was for MempoolState<PartialState> and you didn't want it to be used
This change is