Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(mempool): flow test send tx twice #519

Closed

Conversation

MohammadNassar1
Copy link
Contributor

@MohammadNassar1 MohammadNassar1 commented Jul 22, 2024

This change is Reviewable

Copy link
Contributor Author

@MohammadNassar1 MohammadNassar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @ayeletstarkware, @elintul, and @giladchase)

a discussion (no related file):
Test that sending the same transaction twice works successfully when a transaction was reverted in commit_block.



crates/mempool/src/mempool_test.rs line 426 at r1 (raw file):

#[rstest]
#[ignore]

Waiting for commit_block PRs, and this PR which enables recursive get_txs.

Code quote:

#[ignore]

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.20%. Comparing base (c9f77e7) to head (5445068).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #519   +/-   ##
=======================================
  Coverage   83.20%   83.20%           
=======================================
  Files          37       37           
  Lines        1786     1786           
  Branches     1786     1786           
=======================================
  Hits         1486     1486           
  Misses        222      222           
  Partials       78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @ayeletstarkware, @giladchase, and @MohammadNassar1)

a discussion (no related file):
Please apply my other test PR comments here.



crates/mempool/src/mempool_test.rs line 426 at r1 (raw file):

Previously, MohammadNassar1 (mohammad-starkware) wrote…

Waiting for commit_block PRs, and this PR which enables recursive get_txs.

You can reference PRs/GitHub issues by number: #499. 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants