Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move deploy_account_tx next to peers #458

Merged
merged 1 commit into from
Jul 14, 2024

Conversation

giladchase
Copy link
Collaborator

@giladchase giladchase commented Jul 11, 2024

Moved next to similar constructors invoke_tx() and declare_tx().

NOTE: Only move, no internal changes.


This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.38%. Comparing base (fdb417f) to head (6ef0fdc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #458   +/-   ##
=======================================
  Coverage   83.38%   83.38%           
=======================================
  Files          37       37           
  Lines        1769     1769           
  Branches     1769     1769           
=======================================
  Hits         1475     1475           
  Misses        215      215           
  Partials       79       79           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Yael-Starkware Yael-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

Base automatically changed from gilad/deploy-gen to main July 14, 2024 10:34
Moved next to similar constructors `invoke_tx()` and `declare_tx()`.

NOTE: Only move, no internal changes.
@giladchase giladchase force-pushed the gilad/move-constructors branch from b1631d9 to 6ef0fdc Compare July 14, 2024 12:31
Copy link
Collaborator Author

@giladchase giladchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @ArniStarkware and @Yael-Starkware)

Copy link
Collaborator Author

@giladchase giladchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

@giladchase giladchase merged commit b1804bb into main Jul 14, 2024
8 checks passed
@giladchase giladchase deleted the gilad/move-constructors branch July 14, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants