-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: simplify state-reader iteration #453
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #453 +/- ##
==========================================
+ Coverage 82.89% 83.51% +0.61%
==========================================
Files 37 37
Lines 1719 1771 +52
Branches 1719 1771 +52
==========================================
+ Hits 1425 1479 +54
+ Misses 217 213 -4
- Partials 77 79 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @ArniStarkware and @giladchase)
-- commits
line 5 at r1:
I think this was your intention.
Suggestion:
`prepare_compiled_contract_classes` shouldn't know about stuff it
isn't using.
`prepare_compiled_contract_classes` shouldn't know about stuff it isn't using.
6892605
to
dda77f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @ArniStarkware and @Yael-Starkware)
Previously, Yael-Starkware (YaelD) wrote…
I think this was your intention.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)
prepare_compiled_contract_classes
should know about stuff it isn't using.This change is