Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify state-reader iteration #453

Merged
merged 1 commit into from
Jul 14, 2024

Conversation

giladchase
Copy link
Collaborator

@giladchase giladchase commented Jul 11, 2024

prepare_compiled_contract_classes should know about stuff it isn't using.


This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.51%. Comparing base (7c08d83) to head (dda77f6).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #453      +/-   ##
==========================================
+ Coverage   82.89%   83.51%   +0.61%     
==========================================
  Files          37       37              
  Lines        1719     1771      +52     
  Branches     1719     1771      +52     
==========================================
+ Hits         1425     1479      +54     
+ Misses        217      213       -4     
- Partials       77       79       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Yael-Starkware Yael-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @ArniStarkware and @giladchase)


-- commits line 5 at r1:
I think this was your intention.

Suggestion:

  `prepare_compiled_contract_classes` shouldn't know about stuff it
  isn't using.

`prepare_compiled_contract_classes` shouldn't know about stuff it
isn't using.
@giladchase giladchase force-pushed the gilad/refactor-pre-contract branch from 6892605 to dda77f6 Compare July 14, 2024 10:35
Copy link
Collaborator Author

@giladchase giladchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @ArniStarkware and @Yael-Starkware)


-- commits line 5 at r1:

Previously, Yael-Starkware (YaelD) wrote…

I think this was your intention.

Done.

Copy link
Contributor

@Yael-Starkware Yael-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

@giladchase giladchase merged commit 7cf243c into main Jul 14, 2024
8 checks passed
@giladchase giladchase deleted the gilad/refactor-pre-contract branch July 14, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants