test(gateway): test RpcStateReader

[yair-starkware]

This change is 

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.78%. Comparing base (73bf292) to head (f4af82a).
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #449      +/-   ##
==========================================
+ Coverage   83.13%   83.78%   +0.65%     
==========================================
  Files          37       37              
  Lines        1737     1819      +82     
  Branches     1737     1819      +82     
==========================================
+ Hits         1444     1524      +80     
- Misses        214      220       +6     
+ Partials       79       75       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dafnamatsry]

Reviewed 5 of 6 files at r1, all commit messages.
Reviewable status: 5 of 6 files reviewed, 2 unresolved discussions (waiting on @yair-starkware)

---

crates/gateway/src/rpc_state_reader_test.rs line 30 at r1 (raw file):

        "params": json!(params),
    }));
    dbg!(serde_json::to_string(&expected_response).unwrap());

needed?

Code quote:

dbg!(serde_json::to_string(&expected_response).unwrap());

---

crates/gateway/src/rpc_state_reader_test.rs line 74 at r1 (raw file):

        let block_info = client.get_block_info().unwrap();
        // TODO(yair): Add partial_eq for BlockInfo and assert_eq the whole BlockInfo.
        assert_eq!(block_info.block_number, BlockNumber(100));

Can we move the assertion outside of the spawn_blocking?
A bit more readable IMO to have all the assertions of the test last. Also, not sure how the a failure inside the spawn_blocking is presented when running the test...

Code quote:

assert_eq!(block_info.block_number, BlockNumber(100));

[yair-starkware]

Reviewable status: 3 of 6 files reviewed, 2 unresolved discussions (waiting on @dafnamatsry)

---

crates/gateway/src/rpc_state_reader_test.rs line 30 at r1 (raw file):

Previously, dafnamatsry wrote…

needed?

Removed

---

crates/gateway/src/rpc_state_reader_test.rs line 74 at r1 (raw file):

Previously, dafnamatsry wrote…

Can we move the assertion outside of the spawn_blocking?
A bit more readable IMO to have all the assertions of the test last. Also, not sure how the a failure inside the spawn_blocking is presented when running the test...

Done.

[dafnamatsry]

Reviewed 2 of 3 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @yair-starkware)