fix: remove unnecessary cfg and import #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #424 +/- ##
==========================================
- Coverage 83.68% 83.46% -0.22%
==========================================
Files 37 37
Lines 1710 1718 +8
Branches 1710 1718 +8
==========================================
+ Hits 1431 1434 +3
- Misses 202 206 +4
- Partials 77 78 +1 ☔ View full report in Codecov by Sentry. |
giladchase
force-pushed
the
gilad/config-test-fix
branch
from
6d466e3 to
2e5664e
Compare
- cfg seemed to be a combo of a logical merge conflict and legacy code. Anyway, the whole test is conditionally compiled so adding cfg(test) is basically a nop. Also there is no `testing` feature in this crate :P - Import `self` is only necessary when other imports from the crate are needed.
giladchase
force-pushed
the
gilad/config-test-fix
branch
from
2e5664e to
b0ec228
Compare
giladchase
changed the title
ArniStarkware
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @uriel-starkware)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cfg seemed to be a combo of a logical merge conflict and legacy code. Anyway, the whole test is conditionally compiled so adding cfg(test) is basically a nop.
Also there is no
testingfeature in this crate :PImport
selfis only necessary when other imports from the crate are needed.This change is