Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: align default config with python gateway #405

Merged

Conversation

ArniStarkware
Copy link
Contributor

@ArniStarkware ArniStarkware commented Jul 8, 2024

This change is Reviewable

Copy link
Contributor Author

ArniStarkware commented Jul 8, 2024

Copy link
Contributor

@yair-starkware yair-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry and @Yael-Starkware)

@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.85%. Comparing base (3c861c1) to head (5605a69).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #405      +/-   ##
==========================================
- Coverage   83.87%   83.85%   -0.02%     
==========================================
  Files          37       37              
  Lines        1705     1703       -2     
  Branches     1705     1703       -2     
==========================================
- Hits         1430     1428       -2     
  Misses        200      200              
  Partials       75       75              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor Author

ArniStarkware commented Jul 9, 2024

Merge activity

@ArniStarkware ArniStarkware changed the base branch from arni/chore/config/max_bytecode_size to main July 9, 2024 10:06
@ArniStarkware ArniStarkware force-pushed the arni/gateway/config/align_with_existing_default_1 branch from 1663dd9 to 5605a69 Compare July 9, 2024 10:07
Copy link
Collaborator

@dafnamatsry dafnamatsry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Yael-Starkware)

@ArniStarkware ArniStarkware merged commit f81d8a4 into main Jul 10, 2024
8 checks passed
@ArniStarkware ArniStarkware deleted the arni/gateway/config/align_with_existing_default_1 branch August 21, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants