Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gateway): change inner modules to be private #404

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

yair-starkware
Copy link
Contributor

@yair-starkware yair-starkware commented Jul 8, 2024

This change is Reviewable

@yair-starkware yair-starkware self-assigned this Jul 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.56%. Comparing base (4269f5b) to head (974b39f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #404      +/-   ##
==========================================
- Coverage   83.24%   82.56%   -0.69%     
==========================================
  Files          36       37       +1     
  Lines        1695     1709      +14     
  Branches     1695     1709      +14     
==========================================
  Hits         1411     1411              
- Misses        209      223      +14     
  Partials       75       75              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dafnamatsry and @yair-starkware)


crates/gateway/src/lib.rs line 5 at r1 (raw file):

pub mod compiler_version;
pub mod config;
pub mod errors;

Out of curiosity: why not only gateway?
Are all the rest used by other crates?

@yair-starkware
Copy link
Contributor Author

crates/gateway/src/lib.rs line 5 at r1 (raw file):

Previously, elintul (Elin) wrote…

Out of curiosity: why not only gateway?
Are all the rest used by other crates?

Yes.
I think the correct way is to move the modules into a more nested structure, but this can be done in a separate PR.

Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry)

Copy link
Collaborator

@dafnamatsry dafnamatsry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yair-starkware)

@yair-starkware yair-starkware merged commit fcae59b into main Jul 10, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants