-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add transaction getter to mempool #402
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #402 +/- ##
==========================================
- Coverage 83.24% 82.65% -0.59%
==========================================
Files 36 38 +2
Lines 1695 1753 +58
Branches 1695 1753 +58
==========================================
+ Hits 1411 1449 +38
- Misses 209 229 +20
Partials 75 75 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Yael-Starkware)
crates/mempool/src/transaction_pool.rs
line 62 at r1 (raw file):
} pub fn get(&self, tx_hash: TransactionHash) -> MempoolResult<&ThinTransaction> {
Suggestion:
get_by_tx_hash
crates/mempool/src/transaction_pool.rs
line 66 at r1 (raw file):
} pub fn get_by_account(
Suggestion:
get_by_address_and_nonce
871ad40
to
29bca38
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @elintul)
crates/mempool/src/transaction_pool.rs
line 62 at r1 (raw file):
} pub fn get(&self, tx_hash: TransactionHash) -> MempoolResult<&ThinTransaction> {
done
crates/mempool/src/transaction_pool.rs
line 66 at r1 (raw file):
} pub fn get_by_account(
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Yael-Starkware)
a discussion (no related file):
Please change the commit message: "add getter by address and nonce to TransactionPool".
29bca38
to
aee5b13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Yael-Starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Yael-Starkware)
This change is