test(gateway): make sure we are using the latest block in the stateful validator

[yair-starkware]

This change is 

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.61%. Comparing base (7f2356e) to head (1efb99d).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #401   +/-   ##
=======================================
  Coverage   82.60%   82.61%           
=======================================
  Files          39       39           
  Lines        1788     1789    +1     
  Branches     1788     1789    +1     
=======================================
+ Hits         1477     1478    +1     
  Misses        237      237           
  Partials       74       74           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[elintul]

Reviewed 3 of 7 files at r1, all commit messages.
Reviewable status: 3 of 7 files reviewed, 1 unresolved discussion (waiting on @dafnamatsry and @yair-starkware)

---

crates/gateway/src/state_reader.rs line 16 at r1 (raw file):

}

#[automock]

What does it mean?
Is there an alternative to incorporating testing code into production code?

Code quote:

#[automock]

[yair-starkware]

crates/gateway/src/state_reader.rs line 16 at r1 (raw file):

Previously, elintul (Elin) wrote…

What does it mean?
Is there an alternative to incorporating testing code into production code?

It is a tool to create mocks of traits.
Changed the code so it is behind 'test' feature.

Please note that this PR is on top of #369

[dafnamatsry]

Reviewed 6 of 7 files at r1, 2 of 5 files at r3, 3 of 4 files at r4, all commit messages.
Reviewable status: 6 of 7 files reviewed, 3 unresolved discussions (waiting on @elintul and @yair-starkware)

---

crates/gateway/src/stateful_transaction_validator_test.rs line 81 at r4 (raw file):

    // Using Arc and cloning because mock requires moving the state_reader_factory, but we need it
    // twice.
    let state_reader_factory =

IIUC we need this factory only to create a state_reader to be returned from the mock factory.
Can we just create a TestStateReader directly here? somthing like:

let test_state_reader = Box::new(...);
mock_state_reader_factory
    .expect_get_state_reader_from_latest_block()
    .returning(move || test_state_reader);

---

crates/gateway/src/stateful_transaction_validator_test.rs line 97 at r4 (raw file):

        assert_eq!(block_number, state_reader_factory.state_reader.block_info.block_number);
        state_reader_factory.get_state_reader(block_number)
    });

Suggestion:

    mock_state_reader_factory.expect_get_state_reader().with(eq(block_number)).returning(move |block_number| {
        state_reader_factory.get_state_reader(block_number)
    });

[yair-starkware]

Reviewable status: 3 of 7 files reviewed, 3 unresolved discussions (waiting on @dafnamatsry and @elintul)

---

crates/gateway/src/stateful_transaction_validator_test.rs line 81 at r4 (raw file):

Previously, dafnamatsry wrote…

IIUC we need this factory only to create a state_reader to be returned from the mock factory.
Can we just create a TestStateReader directly here? somthing like:

let test_state_reader = Box::new(...);
mock_state_reader_factory
    .expect_get_state_reader_from_latest_block()
    .returning(move || test_state_reader);

Done.

---

crates/gateway/src/stateful_transaction_validator_test.rs line 97 at r4 (raw file):

        assert_eq!(block_number, state_reader_factory.state_reader.block_info.block_number);
        state_reader_factory.get_state_reader(block_number)
    });

Done.

[dafnamatsry]

Reviewed 4 of 4 files at r6, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @elintul)

[elintul]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yair-starkware)

---

crates/gateway/src/state_reader.rs line 16 at r1 (raw file):

Previously, yair-starkware (Yair) wrote…

It is a tool to create mocks of traits.
Changed the code so it is behind 'test' feature.

Please note that this PR is on top of #369

Please add Gilad as a reviewer, would like his opinion here.

[yair-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @elintul and @giladchase)

---

crates/gateway/src/state_reader.rs line 16 at r1 (raw file):

Previously, elintul (Elin) wrote…

Please add Gilad as a reviewer, would like his opinion here.

Done.

[elintul]

Reviewed 2 of 5 files at r3, 1 of 4 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @giladchase)

[dafnamatsry]

Reviewed 6 of 6 files at r7, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @giladchase)