Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tracing #390

Merged
merged 1 commit into from
Jul 8, 2024
Merged

feat: add tracing #390

merged 1 commit into from
Jul 8, 2024

Conversation

lev-starkware
Copy link
Contributor

@lev-starkware lev-starkware commented Jul 7, 2024

This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 82.93%. Comparing base (29d3e19) to head (f6e5bda).

Files Patch % Lines
crates/mempool_node/src/main.rs 0.00% 13 Missing ⚠️
crates/mempool_infra/src/component_server.rs 0.00% 0 Missing and 2 partials ⚠️
crates/gateway/src/gateway.rs 0.00% 0 Missing and 1 partial ⚠️
crates/mempool_node/src/servers.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #390      +/-   ##
==========================================
- Coverage   83.49%   82.93%   -0.56%     
==========================================
  Files          36       36              
  Lines        1684     1694      +10     
  Branches     1684     1694      +10     
==========================================
- Hits         1406     1405       -1     
- Misses        204      214      +10     
- Partials       74       75       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @lev-starkware)

Copy link
Contributor Author

@lev-starkware lev-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 9 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @lev-starkware)

@lev-starkware lev-starkware merged commit ee00940 into main Jul 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants