refactor: return an error in case response deserialization fails

[uriel-starkware]

This change is 

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (main@fb92713). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Files	Patch %	Lines
crates/mempool_infra/src/component_client.rs	50.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #377   +/-   ##
=======================================
  Coverage        ?   80.70%           
=======================================
  Files           ?       35           
  Lines           ?     1622           
  Branches        ?     1622           
=======================================
  Hits            ?     1309           
  Misses          ?      246           
  Partials        ?       67           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Itay-Tsabary-Starkware]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @uriel-starkware)

---

crates/mempool_infra/src/component_client.rs line 125 at r1 (raw file):

    #[error("Got an unexpected response type.")]
    UnexpectedResponse,
    #[error("Could not deserialize response from server.")]

Please change to "server response"

Code quote:

response from server

[Itay-Tsabary-Starkware]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @uriel-starkware)

---

crates/mempool_infra/src/component_client.rs line 96 at r1 (raw file):

            .await
            .map_err(ClientError::ResponseParsingFailure)?;
        deserialize(&body_bytes).map_err(|_e| ClientError::ResponseDeserializationFailure)

Can the error _e be in ClientError::ResponseDeserializationFailure?

Code quote:

.map_err(|_e| ClientError::ResponseDeserializationFailure)

[uriel-starkware]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Itay-Tsabary-Starkware)

---

crates/mempool_infra/src/component_client.rs line 96 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Can the error _e be in ClientError::ResponseDeserializationFailure?

I can convert it to string, is that fine?

---

crates/mempool_infra/src/component_client.rs line 125 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Please change to "server response"

ok

[Itay-Tsabary-Starkware]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @uriel-starkware)