Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: request 0 txs from get_txs test #365

Merged
merged 1 commit into from
Jul 7, 2024

Conversation

ayeletstarkware
Copy link
Contributor

@ayeletstarkware ayeletstarkware commented Jul 4, 2024

This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.80%. Comparing base (a2b8df2) to head (2dbc7ca).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #365   +/-   ##
=======================================
  Coverage   80.80%   80.80%           
=======================================
  Files          35       35           
  Lines        1620     1620           
  Branches     1620     1620           
=======================================
  Hits         1309     1309           
  Misses        245      245           
  Partials       66       66           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ayeletstarkware and @MohammadNassar1)


crates/mempool/src/mempool_test.rs line 65 at r1 (raw file):

#[case(3)] // Requesting exactly the number of transactions in the queue
#[case(5)] // Requesting more transactions than are in the queue
#[case(2)] // Requesting fewer transactions than are in the queue

Suggestion:

#[case::test_get_zero_txs(0)]
#[case::test_get_exactly_all_eligible_txs(3)]
#[case::test_get_more_than_all_eligible_txs(5)]
#[case::test_get_less_than_all_eligible_txs(2)]

@ayeletstarkware ayeletstarkware force-pushed the ayelet/mempool/request-0-txs-from-get-txs branch from bdb8c4c to 234678d Compare July 4, 2024 13:12
Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @MohammadNassar1)

@ayeletstarkware ayeletstarkware force-pushed the ayelet/mempool/transaction-queue-iter-func branch from 919b369 to 04203ff Compare July 7, 2024 08:27
@ayeletstarkware ayeletstarkware changed the base branch from ayelet/mempool/transaction-queue-iter-func to main July 7, 2024 09:59
@ayeletstarkware ayeletstarkware force-pushed the ayelet/mempool/request-0-txs-from-get-txs branch from 234678d to 2dbc7ca Compare July 7, 2024 10:00
Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @MohammadNassar1)

@ayeletstarkware ayeletstarkware merged commit 8e3825b into main Jul 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants