Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: code to compilation file from gateway #344

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

ArniStarkware
Copy link
Contributor

@ArniStarkware ArniStarkware commented Jul 2, 2024

This change is Reviewable

Copy link
Contributor Author

ArniStarkware commented Jul 2, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on Graphite Graphite

@ArniStarkware ArniStarkware marked this pull request as ready for review July 2, 2024 12:26
@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 86.20690% with 8 lines in your changes missing coverage. Please review.

Project coverage is 82.50%. Comparing base (c553217) to head (0f229c0).

Files Patch % Lines
crates/gateway/src/compilation.rs 86.20% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@                                       Coverage Diff                                        @@
##           arni/declare/post_compilation/validation/trait_for_builtin_name     #344   +/-   ##
================================================================================================
  Coverage                                                            82.50%   82.50%           
================================================================================================
  Files                                                                   32       33    +1     
  Lines                                                                 1623     1623           
  Branches                                                              1623     1623           
================================================================================================
  Hits                                                                  1339     1339           
  Misses                                                                 219      219           
  Partials                                                                65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/compilation_file branch 3 times, most recently from 31fc7d7 to 99c0672 Compare July 2, 2024 13:06
@ArniStarkware ArniStarkware changed the base branch from main to arni/declare/post_compilation/validation/trait_for_builtin_name July 2, 2024 13:06
@ArniStarkware ArniStarkware force-pushed the arni/declare/post_compilation/validation/trait_for_builtin_name branch 3 times, most recently from 361094e to 255fbad Compare July 2, 2024 14:59
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/compilation_file branch from 99c0672 to 8169305 Compare July 2, 2024 15:03
@ArniStarkware ArniStarkware force-pushed the arni/declare/post_compilation/validation/trait_for_builtin_name branch from 255fbad to ac80823 Compare July 2, 2024 15:42
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/compilation_file branch from 8169305 to 4733c8e Compare July 2, 2024 15:43
@ArniStarkware ArniStarkware force-pushed the arni/declare/post_compilation/validation/trait_for_builtin_name branch from ac80823 to afdd207 Compare July 3, 2024 07:15
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/compilation_file branch from 4733c8e to 2546a4b Compare July 3, 2024 07:15
@ArniStarkware ArniStarkware force-pushed the arni/declare/post_compilation/validation/trait_for_builtin_name branch from afdd207 to e87b419 Compare July 3, 2024 09:11
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/compilation_file branch from 2546a4b to 6a332d4 Compare July 3, 2024 09:12
@ArniStarkware ArniStarkware force-pushed the arni/declare/post_compilation/validation/trait_for_builtin_name branch from e87b419 to c553217 Compare July 3, 2024 10:03
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/compilation_file branch from 6a332d4 to 0f229c0 Compare July 3, 2024 10:03
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/compilation_file branch from 0f229c0 to 93e2b1b Compare July 3, 2024 12:02
@ArniStarkware ArniStarkware changed the base branch from arni/declare/post_compilation/validation/trait_for_builtin_name to main July 3, 2024 12:02
@ArniStarkware
Copy link
Contributor Author

+reviewer:@Yael-Starkware

@ArniStarkware
Copy link
Contributor Author

This PR is (almost only) copy-past of code from one file to another.

@ArniStarkware
Copy link
Contributor Author

crates/gateway/src/gateway.rs line 37 at r1 (raw file):

pub mod gateway_test;

pub type GatewayResult<T> = Result<T, GatewayError>;

Moved to errors

Code quote:

pub type GatewayResult<T> = Result<T, GatewayError>;

Copy link
Contributor

@Yael-Starkware Yael-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

@ArniStarkware ArniStarkware merged commit 26060ef into main Jul 3, 2024
7 checks passed
@ArniStarkware ArniStarkware deleted the arni/declare/compilation/compilation_file branch August 21, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants