Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make generic component server http #337

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

uriel-starkware
Copy link
Contributor

@uriel-starkware uriel-starkware commented Jul 1, 2024

This change is Reviewable

Copy link
Contributor Author

@uriel-starkware uriel-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @uriel-starkware)

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 89.47368% with 4 lines in your changes missing coverage. Please review.

Project coverage is 83.03%. Comparing base (6ec0d90) to head (6c324f2).

Files Patch % Lines
crates/mempool_infra/src/component_server.rs 89.47% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #337      +/-   ##
==========================================
+ Coverage   82.87%   83.03%   +0.16%     
==========================================
  Files          31       31              
  Lines        1489     1527      +38     
  Branches     1489     1527      +38     
==========================================
+ Hits         1234     1268      +34     
- Misses        195      196       +1     
- Partials       60       63       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lev-starkware lev-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @uriel-starkware)

@uriel-starkware uriel-starkware merged commit 6734b2d into main Jul 1, 2024
13 checks passed
@uriel-starkware uriel-starkware deleted the uriel/generic-component-server-http branch July 1, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants