Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete CompileContractClass object #335

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

Yael-Starkware
Copy link
Contributor

@Yael-Starkware Yael-Starkware commented Jul 1, 2024

This change is Reviewable

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.06%. Comparing base (3243dd2) to head (61b594f).
Report is 33 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #335      +/-   ##
==========================================
+ Coverage   77.01%   78.06%   +1.05%     
==========================================
  Files          28       28              
  Lines        1379     1409      +30     
  Branches     1379     1409      +30     
==========================================
+ Hits         1062     1100      +38     
+ Misses        262      254       -8     
  Partials       55       55              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Yael-Starkware Yael-Starkware force-pushed the yael/delete_compiled_contract_class_object branch from 61b594f to a884e2b Compare July 1, 2024 12:30
@Yael-Starkware Yael-Starkware changed the title Yael/delete compiled contract class object chore: delete CompileContractClass object Jul 1, 2024
Copy link
Collaborator

@dafnamatsry dafnamatsry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 7 files at r1, 6 of 6 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

@Yael-Starkware Yael-Starkware merged commit f5d41a4 into main Jul 2, 2024
12 of 13 checks passed
@Yael-Starkware Yael-Starkware deleted the yael/delete_compiled_contract_class_object branch July 2, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants