feat: make generic component client http

[uriel-starkware]

This change is 

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.64%. Comparing base (d7017e8) to head (45db391).
Report is 10 commits behind head on main.

Files	Patch %	Lines
crates/mempool_infra/src/component_client.rs	90.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #334      +/-   ##
==========================================
- Coverage   83.98%   82.64%   -1.35%     
==========================================
  Files          28       31       +3     
  Lines        1374     1596     +222     
  Branches     1374     1596     +222     
==========================================
+ Hits         1154     1319     +165     
- Misses        161      216      +55     
- Partials       59       61       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Itay-Tsabary-Starkware]

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @uriel-starkware)

---

crates/mempool_infra/src/component_client.rs line 62 at r1 (raw file):

where
    Request: Serialize,
    Response: for<'a> Deserialize<'a>,

Please add the bounds to the struct definition as well.

Code quote:

where
    Request: Serialize,
    Response: for<'a> Deserialize<'a>,

[Itay-Tsabary-Starkware]

Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @uriel-starkware)

---

crates/mempool_infra/tests/component_server_client_http_test.rs line 197 at r1 (raw file):

    let a_client = ComponentClientHttp::new(local_ip, a_port);
    let b_client = ComponentClientHttp::new(local_ip, b_port);

Is there a way to explicitly mention the types of these two? Currently they are implicilty inferred from the initation of the components.

Something in the sorts of

    let a_client = ComponentClientHttp<RequestA,ResponseA>::new(local_ip, a_port);

Code quote:

    let a_client = ComponentClientHttp::new(local_ip, a_port);
    let b_client = ComponentClientHttp::new(local_ip, b_port);

[uriel-starkware]

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion

---

crates/mempool_infra/src/component_client.rs line 62 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Please add the bounds to the struct definition as well.

Done.

---

crates/mempool_infra/tests/component_server_client_http_test.rs line 197 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Is there a way to explicitly mention the types of these two? Currently they are implicilty inferred from the initation of the components.

Something in the sorts of

    let a_client = ComponentClientHttp<RequestA,ResponseA>::new(local_ip, a_port);

there is always the option to write them as ComponentClientHttp<ComponentARequest, ComponentAResponse>. Tell me if this is what you want. I will do it to server as well

[uriel-starkware]

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)

---

crates/mempool_infra/tests/component_server_client_http_test.rs line 197 at r1 (raw file):

Previously, uriel-starkware wrote…

there is always the option to write them as ComponentClientHttp<ComponentARequest, ComponentAResponse>. Tell me if this is what you want. I will do it to server as well

Ok, I did it as I described

[Itay-Tsabary-Starkware]

Reviewed 1 of 3 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @uriel-starkware)