Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use assert_eq for Ok MempoolResult #276

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Conversation

giladchase
Copy link
Collaborator

@giladchase giladchase commented Jun 25, 2024

Uses pretty_assertions, colored and formatted output.

commit-id:5dc07b7c


This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.55%. Comparing base (71d556d) to head (c64d6cc).

Files Patch % Lines
crates/mempool_types/src/errors.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           spr/main/31a827be     #276   +/-   ##
==================================================
  Coverage              78.55%   78.55%           
==================================================
  Files                     27       27           
  Lines                   1236     1236           
  Branches                1236     1236           
==================================================
  Hits                     971      971           
  Misses                   208      208           
  Partials                  57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@MohammadNassar1 MohammadNassar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

Copy link
Contributor

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @giladchase)

@giladchase giladchase changed the base branch from spr/main/286e5e96 to main June 25, 2024 11:16
@giladchase giladchase force-pushed the spr/main/5dc07b7c branch 2 times, most recently from 3473dc6 to c64d6cc Compare June 25, 2024 11:32
@giladchase giladchase changed the base branch from main to spr/main/31a827be June 25, 2024 11:32
Uses pretty_assertions, colored and formatted output.

commit-id:5dc07b7c
@giladchase giladchase changed the base branch from spr/main/31a827be to main June 25, 2024 11:35
Copy link
Collaborator Author

@giladchase giladchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @giladchase)

@giladchase giladchase merged commit a7477f1 into main Jun 25, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants