refactor: use mempool::empty everywhere #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giladchase
force-pushed
the
gilad/mempool-empty
branch
from
13e093b to
268b68e
Compare
giladchase
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #271 +/- ##
==========================================
- Coverage 78.64% 78.57% -0.08%
==========================================
Files 26 26
Lines 1194 1190 -4
Branches 1194 1190 -4
==========================================
- Hits 939 935 -4
Misses 201 201
Partials 54 54 ☔ View full report in Codecov by Sentry. |
giladchase
force-pushed
the
gilad/mempool-empty
branch
from
268b68e to
601fcbd
Compare
giladchase
changed the title
Also impl with `Default`.
giladchase
force-pushed
the
gilad/mempool-empty
branch
from
601fcbd to
6ec6fc8
Compare
MohammadNassar1
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @elintul)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And impl via Default
This change is